Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JDK-version dependent code out of the compiler bridge #327

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Remove JDK-version dependent code out of the compiler bridge #327

merged 1 commit into from
Jun 30, 2017

Commits on Jun 30, 2017

  1. Move CompilerBridgeProvider.constant into ZincCompilerUtil 

    On both my local machine and on Drone box, `ZincComponentCompilerSpec` fails to compile 2.10 compiler bridge with the following error:

```
/T/sbt_1234/xsbti/compile/CompilerBridgeProvider.java:33: error: `;' expected but `{' found.
    static CompilerBridgeProvider constant(File file, ScalaInstance scalaInstance) {
                                                                                   ^
```

I suspected that this is due to Java `interface` defining a static method, a change introduced in only in Java 8.
After making this change, the spec passed the test.
    @eed3si9n
    eed3si9n committed Jun 30, 2017
    Configuration menu
    Copy the full SHA
    82cdf80 View commit details
    Browse the repository at this point in the history