Fix handling deeply nested java classes. #423
Conversation
|
|
||
| def loadEnclosingClass(clazz: Class[_]): Option[String] = { | ||
| binaryToSourceName(clazz) match { | ||
| case None if loadedClass.getEnclosingClass != null => |
There was a problem hiding this comment.
I think you mean clazz.getEnclosingClass != null here.
There was a problem hiding this comment.
How was the test case even passing with this error? This would mean that more than one level of nesting would not be handled.
There was a problem hiding this comment.
Tests passes since if loadedClass is nested class (regardless how deep) it will be always null.
The only problem with this is that in case that for some reason we don't have source mapping for top enclosing class we will get NullPointerException here. But anyway this was stupid mistake.
| import sbt.internal.inc.Analysis | ||
| import sbt.io.IO | ||
|
|
||
| /** |
There was a problem hiding this comment.
Can we remove this header? We don't use them anywhere in the project.
| case analysis: Analysis => | ||
| analysis.relations.libraryDep._2s | ||
| .filter(_.toPath.startsWith(tempDir.toPath)) shouldBe 'empty | ||
|
|
|
|
||
| def loadEnclosingClass(clazz: Class[_]): Option[String] = { | ||
| binaryToSourceName(clazz) match { | ||
| case None if loadedClass.getEnclosingClass != null => |
There was a problem hiding this comment.
How was the test case even passing with this error? This would mean that more than one level of nesting would not be handled.
romanowski
force-pushed
the
fix-nested-java-classes
branch
2 times, most recently
from
85bd8a9
to
2aa65c5
Compare
Without fix it reports dependencies to jar/classes produced by same project.
romanowski
force-pushed
the
fix-nested-java-classes
branch
from
2aa65c5
to
e792676
Compare
Without fix it reports dependencies to jar/classes produced by same project.