-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move REPL related xsbti Java classes to the correct module #425
Conversation
xsbti Java classes were ported into compiler bridge, instead of the compiler interface by mistake. Since there's not code utilizing this interface yet, this was never caught.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change required by anything, or is it just cleaning up? Just curious. LGTM.
Over the weekend I was actually trying to implement something using this feature, and realized that it's broken. |
build.sbt
Outdated
@@ -387,6 +387,14 @@ lazy val compilerBridge: Project = (project in internalPath / "compiler-bridge") | |||
publishLocal := publishLocal.dependsOn(cleanSbtBridge).value, | |||
altPublishSettings, | |||
mimaSettings, | |||
mimaBinaryIssueFilters ++= Vector( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should follow the scalac standard of having this in an independent file. I don't like having this on the build.sbt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you elaborate why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can think of two reasons:
- Every time I change something, It makes me reload the build.
- A file inside a project's source directories is clearer to find and read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 505ac2e
ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleFactory") | ||
ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleResult") | ||
ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleInterface") | ||
ProblemFilters.exclude[MissingClassProblem]("xsbti.InteractiveConsoleResponse") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mima exclusions moved to its own file, so is this ready to merge?
xsbti
Java classes were ported into compiler bridge, instead of the compiler interface by mistake.Since there's not code utilizing this interface yet, this was never caught.
Ref #295