Fix #127: Use unexpanded names #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It looks like scalac encodes access rights of objects in their names. To make sure that we get the right simple names, we need to use `unexpandedName` instead of `name` which will decipher these access rights and return their simple names insted (with all the previous `$$` prefixes stripped out).
|
Damn, I forgot to add the "Fix ..." in the commit message and not the title. |
|
This is ready for review. |
dwijnand
approved these changes
Oct 15, 2017
Duhemm
approved these changes
Oct 16, 2017
| object Foo { | ||
| private[issue127] class Bippy | ||
| // This one is problematic because of expanded names | ||
| private[issue127] object Bippy |
There was a problem hiding this comment.
I thought @eed3si9n said no Bippys? 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like scalac encodes access rights of objects in their names. To
make sure that we get the right simple names, we need to use
unexpandedNameinstead ofnamewhich will decipher these accessrights and return their simple names instead (with all the previous
$$prefixes stripped out).
Fix #127