Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Argument list too long: recursive header expansion failed" issue #275

Merged
merged 1 commit into from
May 30, 2018

Conversation

lebedev
Copy link
Contributor

@lebedev lebedev commented Mar 23, 2018

Fixes #209.

See this comment, and this comment.

@zoi-aoba
Copy link

zoi-aoba commented Apr 7, 2018

This is nice PR

@koenpunt
Copy link
Collaborator

koenpunt commented Apr 9, 2018

Thanks! Sorry for the late reply. Do you have any idea why this solves the issue?

@lebedev
Copy link
Contributor Author

lebedev commented Apr 9, 2018

@koenpunt Can't say for sure, but this is what I think:

I suspect that Argument list too long: recursive header expansion failed issue happens when a pod tries to search just through too many files. In ios/** there usually many unrelated files, e.g. ios/build folder with a ton of building artifacts, when actually related files are located in ios/Pods/** somewhere. Thus narrowing search locations to Pods folder prevents argument list from exploding sometimes.

@koenpunt
Copy link
Collaborator

koenpunt commented Apr 9, 2018

Sounds acceptable. I'll see if I can make the search paths even more specific, and if that doesn't work I'll merge as-is. Thanks! 🚀

@evanjmg
Copy link

evanjmg commented May 30, 2018

Please merge. I had to make these changes in my project

@koenpunt koenpunt merged commit f8db0e6 into sbugert:master May 30, 2018
@lebedev lebedev deleted the patch-1 branch May 30, 2018 22:14
@evanjmg
Copy link

evanjmg commented Jun 2, 2018

This worked at one point, now getting this

Argument list too long: recursive header expansion failed at /Users/evanjmg/Desktop/development/cryptoBuyer/Bullish/node_modules/react-native-admob/ios/../../../ios/Pods/React/node_modules/react-tools/src/isomorphic/classic/element/__tests__

@lebedev
Copy link
Contributor Author

lebedev commented Jun 2, 2018

@evanjmg I had a lot of issues with my project as well, and the solution in my case was to stop including react-native-* packages as pods. When I started including them manually in Xcode, many issues have suddenly disappeared. It's slightly less convenient now than I'm unable to use react-native link command, but with some packages it was working incorrectly (like placing files in Recovered References section) anyway, and it's not like I include/exclude packages from my project often, so it was totally worth it.

@rawrmaan
Copy link

This change prevents the project from working properly with manual linking (no CocoaPods). It can't find the GoogleMobileAds framework.

@koenpunt
Copy link
Collaborator

@rawrmaan you have to add GoogleMobileAds to your project yourself.

@rawrmaan
Copy link

@koenpunt Yeah, I know. For some reason, this change prevents Xcode from finding the framework added to my project. I have my own branch where I reverted the change and it works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants