-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform ternary conditional injections before branch injections (#828) #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgewecke
changed the title
Inject ternary conditionals before branches
Inject ternary conditionals after branches
Jan 25, 2024
cgewecke
changed the title
Inject ternary conditionals after branches
Perform ternary conditional injections before branch injections (#828)
Jan 25, 2024
This was referenced Jul 17, 2024
This was referenced Aug 2, 2024
This was referenced Aug 6, 2024
This was referenced Aug 16, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #821, a ternary conditional is placed directly after an unbracketed
else
statement as belowSeveral injections are necessary at the same location here and the order in which they happen matters. Because the branch injection for the
else
occurred first, it was being located inside the ternary clause as belowThis PR explicitly prioritizes branch injections over conditional component injections