-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extendConfig logic for hardhat-viem plugin #883
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
==========================================
+ Coverage 96.45% 96.61% +0.15%
==========================================
Files 19 19
Lines 1045 1062 +17
==========================================
+ Hits 1008 1026 +18
+ Misses 37 36 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jul 17, 2024
This was referenced Aug 2, 2024
This was referenced Aug 6, 2024
This was referenced Aug 16, 2024
This was referenced Sep 1, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#874, #819
PR adds logic to support the
hardhat-viem
plugin. If you run the env variable set as below it will configure the hardhat network correctly in theextendConfig
hook and skip provider redefinition at the task level.This approach is necessary because there's no way to know from within
extendConfig
whether the coverage task is actually being run and therefore no safe way to redefine the network settings.If
viem
is defined in the hardhat environment and the network has not been set with the correct defaults, an error is thrown: