-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cordl 1.0.0 #12
Open
Fernthedev
wants to merge
686
commits into
sc2ad:master
Choose a base branch
from
QuestPackageManager:dev/generic_methods_redo
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cordl 1.0.0 #12
Fernthedev
wants to merge
686
commits into
sc2ad:master
from
QuestPackageManager:dev/generic_methods_redo
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedBrumbler
reviewed
Sep 20, 2023
src/main.rs
Outdated
} | ||
} | ||
|
||
let write_all = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will mean cordl built from source will not generate all headers for us, this should be set to true probably
Fernthedev
force-pushed
the
dev/generic_methods_redo
branch
2 times, most recently
from
September 22, 2023 20:31
1ca866b
to
9233a58
Compare
…, with TODO for unions of fields
…, with TODO for unions of fields
…dev/cordl into dev/generic_methods_redo
…nto dev/generic_methods_redo
… instance fields in explicitly laid out types
…includes of generic valuetype valuetype template args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #11 and implements everything needed for cordl release.
TODO: Fix anonymous namespace issue causing references to be missing