Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

immutable.HashSet.subsetOf should not invoke hashCode #380

Closed
lrytz opened this issue Jan 27, 2018 · 1 comment
Closed

immutable.HashSet.subsetOf should not invoke hashCode #380

lrytz opened this issue Jan 27, 2018 · 1 comment
Labels
blocker bug in progress low hanging fruit
Milestone
0.10.0

Comments

@lrytz
Copy link
Member

lrytz commented Jan 27, 2018

This test fails: https://github.com/scala/scala/blob/2.13.x/test/files/run/t7326.scala#L45-L61
Added in scala/scala#3315
@julienrf
Copy link
Contributor

It looks like I omitted to copy the implementation of subsetOf for no good reason…
https://github.com/scala/scala/blob/2.13.x/src/library/scala/collection/immutable/HashSet.scala#L74

@julienrf julienrf added this to the 0.10.0 milestone Jan 31, 2018
@julienrf julienrf mentioned this issue Jan 31, 2018
Merged
@julienrf julienrf added in progress and removed ready labels Feb 9, 2018
@julienrf julienrf mentioned this issue Feb 9, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
blocker bug in progress low hanging fruit
Projects
None yet
Milestone
0.10.0
Development

No branches or pull requests
2 participants
@lrytz @julienrf