Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Add back optimizations of HashSet #439

Merged
merged 2 commits into from
Feb 14, 2018
Merged

Conversation

julienrf
Copy link
Contributor

@julienrf julienrf commented Feb 9, 2018

Fixes #380 (I checked it locally but didn’t duplicate the test in our repository).

For some reason when I ported the code of HashSet to the new design I only took the minimum amount of code. This PR also takes optimizations from the old collections and put them in the new collections.

@szeiger
Copy link
Contributor

szeiger commented Feb 9, 2018

What's with all the private[immutable] methods? Are they supposed to be called from outside of HashSet?

@julienrf
Copy link
Contributor Author

julienrf commented Feb 9, 2018

I copy-pasted from the old collections without making them protected but indeed they should be protected, unless maybe there are some tests somewhere in the old collections that rely on these implementation details?

@julienrf
Copy link
Contributor Author

I’ve modified the PR to use protected when possible.

@julienrf julienrf merged commit e38fc1b into scala:master Feb 14, 2018
@julienrf julienrf deleted the hashset-subsetof branch February 14, 2018 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants