Skip to content
This repository has been archived by the owner on Dec 22, 2021. It is now read-only.

Make sure HashSet is at least as performant as in the old collections #442

Closed
julienrf opened this issue Feb 9, 2018 · 2 comments
Closed

Comments

@julienrf
Copy link
Contributor

julienrf commented Feb 9, 2018

In #439 I’ve added benchmarks comparing the main operations of hashsets. In some cases we are still under the performance level of the old HashSet. Also, in some cases ChamHashSet is less performant than HashSet. We have to investigate more before committing to a default Set implementation.

equals

ChamHashSet wins.

excl

The new HashSet wins.

incl

The old HashSet wins!

intersection

New HashSet wins (ex æquo with the old one).

subsetof

ChamHashSet wins for sets with more than 100 elements.

union

No one wins.

@julienrf julienrf added this to the 0.11.0 milestone Feb 19, 2018
@julienrf julienrf added the ready label Feb 19, 2018
@julienrf julienrf removed this from the 0.11.0 milestone Mar 27, 2018
@szeiger szeiger added this to the Scala 2.13.0-M5 milestone Apr 24, 2018
@SethTisue
Copy link
Member

one specific performance minus is being investigated at scala/scala-dev#525

@SethTisue
Copy link
Member

I think is considered resolved now? reopen if you disagree /cc @szeiger @retronym

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants