-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge string-interpolation docs into scala3 book #2839
Merge string-interpolation docs into scala3 book #2839
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Please see my review below.
Thanks Julien, will update with suggestions later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution! Do you mind fixing the Git conflicts so that we can merge the PR?
…core/string-interpolation.md)
…string-interpolation docs
719bb5d
to
dc03bac
Compare
removing the link from Guides & Overviews could probably come in a new PR where we make more sweeping changes to the site's navigation |
thanks @rockpunk for all the work! |
@bishabosha I thought the entry in Guides & Overviews would be removed when we removed the file |
This is my first stab at tackling #2813. There are many changed files mainly due to renumbering the metadata, however the overview of the change is as follows:
string-interpolation
page in scala 3 book based on Josh's excellent_overviews/core/string-interpolation.md
. This is afterfirst-look-at-types
and beforecontrol-structures.md
_overviews/core/string-interpolation.md
tooverviews/scala3-book/string-interpolation.md
first-look-at-types.md
first-look-at-types.md
to its ownStrings
section which describes multiline in more detail and links to newstring-interpolation.md
s/John/James/g
just to be consistent