Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge string-interpolation docs into scala3 book #2839

Merged
merged 8 commits into from
Jun 20, 2023

Conversation

rockpunk
Copy link
Contributor

@rockpunk rockpunk commented Jun 11, 2023

This is my first stab at tackling #2813. There are many changed files mainly due to renumbering the metadata, however the overview of the change is as follows:

  1. Create a new string-interpolation page in scala 3 book based on Josh's excellent _overviews/core/string-interpolation.md. This is after first-look-at-types and before control-structures.md
  2. redirect _overviews/core/string-interpolation.md to overviews/scala3-book/string-interpolation.md
  3. Moved the string interpolation stuff out of first-look-at-types.md
  4. Moved the multi-line string info in first-look-at-types.md to its own Strings section which describes multiline in more detail and links to new string-interpolation.md
  5. Modified the custom interpolator example to give a trivial example so readers could cut/copy working code
  6. s/John/James/g just to be consistent

@rockpunk rockpunk marked this pull request as ready for review June 11, 2023 09:58
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please see my review below.

_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/core/string-interpolation.md Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
_overviews/scala3-book/string-interpolation.md Outdated Show resolved Hide resolved
@julienrf julienrf linked an issue Jun 12, 2023 that may be closed by this pull request
@rockpunk
Copy link
Contributor Author

Thanks Julien, will update with suggestions later.

@julienrf julienrf self-assigned this Jun 14, 2023
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution! Do you mind fixing the Git conflicts so that we can merge the PR?

@julienrf julienrf removed their assignment Jun 19, 2023
@bishabosha bishabosha force-pushed the steve/2813/mv-string-interpolation branch from 719bb5d to dc03bac Compare June 20, 2023 10:46
@bishabosha
Copy link
Member

bishabosha commented Jun 20, 2023

removing the link from Guides & Overviews could probably come in a new PR where we make more sweeping changes to the site's navigation

@bishabosha
Copy link
Member

thanks @rockpunk for all the work!

@julienrf julienrf merged commit 8574b5d into scala:main Jun 20, 2023
@julienrf
Copy link
Contributor

@bishabosha I thought the entry in Guides & Overviews would be removed when we removed the file string-interpolation.md. What should we do instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The String Interpolation guide should be merged into the Scala Book
3 participants