Support for Java 10 class file version 54. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From OW2 commit f835797. It appears there are no changes to the classfile format in Java 10 other than the version bump to 54.
|
Thanks, @quelgar. I plan to update asm to 6.1 (or probably 6.2) for Scala 2.12.7. But I'll keep this PR open for now, just in case I don't get there for some reason. |
|
We've just finished our rebase atop ASM 6.2 and are integrating that into Scala 2.13.x in scala/scala#6733. I'll close this PR now in favour of that upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From OW2 commit f835797.
It appears there are no changes to the classfile format in Java 10 other than the version bump to 54.
The OW2 project has switched to gradle and made major changes to the organisation of their repository. Upgrading scala-asm to version 6.1.1 looks like it would be a lot of work, so I thought I'd try submitting this PR to get Java 10 support.