Add implicit: genericOrderedCompanionToCBF

[fdietze]

fixes #247

I don't know If I'm doing things right here... Help is appreciated.

Please review the new implicit def
What needs to be written in the test?
What needs to be done regarding binary compatibility?

[julienrf]

Thanks a lot for working on this @fdietze.

Here is my review, let me know if you have any question!

[julienrf]

What needs to be done regarding binary compatibility?

We only promise backward compatibility, so your changes seem to be fine. Otherwise we can just bump the version number.

[fdietze]

What needs to be done regarding binary compatibility?

We only promise backward compatibility, so your changes seem to be fine. Otherwise we can just bump the version number.

The version is 2.1.3-SNAPSHOT. should I change it?

[julienrf]

Thanks @fdietze can you please sign the Scala CLA? https://www.lightbend.com/contribute/cla/scala

[fdietze]

Thanks @fdietze can you please sign the Scala CLA? https://www.lightbend.com/contribute/cla/scala

done.

[julienrf]

It seems that we are hitting this issue on 2.11: https://github.com/jatcwang/binary-compatibility-guide#dont-adding-methods-with-default-implementation-to-traits-211-or-before

The version is 2.1.3-SNAPSHOT. should I change it?

Yes, I believe this PR should target a 3.0.0 version. What do others think?

[fdietze]

This PR would hopefully enable scala.rx to cross-compile for 2.13 (lihaoyi/scala.rx#138).

How about the versioning?

[NthPortal]

@fdietze you can fix the bincompat issue by removing the method from PackageShared and adding it to each of the 2.11 and 2.12 package objects. You can see this strategy employed in #288 and #289. If you'd like, I'm happy to do it for you and force-push to this branch.

[fdietze]

It would be nice if you could do it. I'm on holidays right now.
Thank you!

[julienrf]

Thank you both @fdietze and @NthPortal!

[mathieuleclaire]

Did you plan a release soon ? This issue is key to cross compile scala.rx.
Thanks

[julienrf]

You’re right, we should cut a release soon because several improvements have been recently merged.

@NthPortal, do you think you would have time to finish #295 soon or should we do a release now and another one after #295 is merged?

[NthPortal]

@julienrf I'll try to finish up #295 tonight

[NthPortal]

it would be nice to get LazyList into the next release as well, but I understand if that's not a priority

[julienrf]

@NthPortal I won’t be able to help on LazyList before some time, but I agree that we should eventually get it, and thanks a lot for what you’ve done so far.

@SethTisue Do you see anything we should do before pushing the tag?

[SethTisue]

@julienrf I see no reason not to go ahead and release