Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tapEach #291

Merged
merged 2 commits into from
Jan 14, 2020
Merged

Add tapEach #291

merged 2 commits into from
Jan 14, 2020

Conversation

NthPortal
Copy link
Contributor

Fixes #218

@NthPortal NthPortal added the library Related to compat library code (not rewrite rules) label Jan 12, 2020
@NthPortal NthPortal requested a review from julienrf January 12, 2020 09:37
@NthPortal
Copy link
Contributor Author

This is based on top of #288 (because that already added a class for TraversableLike extensions); I'll rebase and clean up the commits once that's merged

julienrf
julienrf approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NthPortal!

compat/src/test/scala/test/scala/collection/CollectionTest.scala Show resolved Hide resolved
@julienrf julienrf merged commit 0144844 into scala:master Jan 14, 2020
@NthPortal NthPortal deleted the topic/tapeach/PR branch January 14, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienrf julienrf julienrf approved these changes

Assignees
No one assigned
Labels
library Related to compat library code (not rewrite rules)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tapEach absent
2 participants
@NthPortal @julienrf