Deprecate update method on i.ArraySeq impls #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NthPortal
added
backport
NthPortal
force-pushed
the
topic/i.ArraySeq.419/PR
branch
from
22deeed to
39ff219
Compare
julienrf
approved these changes
Feb 5, 2021
compat/src/main/scala-2.11_2.12/scala/collection/compat/immutable/ArraySeq.scala
Show resolved
Hide resolved
compat/src/main/scala-2.11_2.12/scala/collection/compat/immutable/ArraySeq.scala
Outdated
Show resolved
Hide resolved
|
@NthPortal squash, then let's merge? |
Deprecate `update` method on `i.ArraySeq` implementations, and change the implementations of the method to throw an `UnsupportedOperationException`.
NthPortal
force-pushed
the
topic/i.ArraySeq.419/PR
branch
from
b002e36 to
3fc9495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate
updatemethod oni.ArraySeqimplementations,and change the implementations of the method to throw
an
UnsupportedOperationException.Fixes #419