Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shift operations to BitSet #43

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

linasm
Copy link
Contributor

@linasm linasm commented Aug 14, 2019

A BitSetDecorator that adds << and >> operations (bitwise shift) to BitSet collections.
Solves #41

Copy link
Collaborator

@julienrf julienrf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you squash your commits?

@linasm
Copy link
Contributor Author

linasm commented Aug 20, 2019

Sure, squashed them.

@julienrf julienrf merged commit 08562cf into scala:master Aug 20, 2019
@julienrf
Copy link
Collaborator

Thanks!

@linasm
Copy link
Contributor Author

linasm commented Aug 21, 2019

@julienrf, I realized that the documentation links which I added to README for BitSet shifts are incorrect (and probably could not be implemented until the next release), sorry for that.
Should I just remove them for now, or maybe a new release is in the near term plans, or could there be some other solution that you would advice?

@julienrf
Copy link
Collaborator

Ah, indeed we will have to update these links at the next release. We should probably do another release soon anyway because we have added a bunch of cool things (BitSet shift operations, splitBy, lazyFoldLeft, Scala.js support).

@SethTisue How do we decide when we should release a 1.0.0 version?

@SethTisue
Copy link
Member

@SethTisue How do we decide when we should release a 1.0.0 version?

um, I don't really have an opinion about that. @szeiger opinion?

@julienrf
Copy link
Collaborator

ping @szeiger

@szeiger
Copy link
Contributor

szeiger commented Aug 30, 2019

Let's look into this after 2.13.1.

@julienrf
Copy link
Collaborator

julienrf commented Sep 2, 2019

I’ve just published a 0.2.0 version, can someone with the appropriate rights release it from the staging repository on Sonatype?
https://travis-ci.org/scala/scala-collection-contrib/builds/579669459

@szeiger
Copy link
Contributor

szeiger commented Sep 2, 2019

I see two open staging repos with 0.2.0. Both appear to have the same JVM artifacts. One additionally has sjsj 1.0.0-M8 artifacts, the other one has sjs 0.6 artifacts.

@julienrf
Copy link
Collaborator

julienrf commented Sep 2, 2019

Both appear to have the same JVM artifacts

Ah, I believe one has been build on jdk11 and the other one on jdk8. We need to tweak the script.

@szeiger
Copy link
Contributor

szeiger commented Sep 2, 2019

Is one of them good for a release or should I delete both?

@julienrf
Copy link
Collaborator

julienrf commented Sep 2, 2019

Unfortunately none of them is complete, you should delete both. Thanks!

@szeiger
Copy link
Contributor

szeiger commented Sep 2, 2019

I just noticed that there are even two repositories with the JVM + ScalaJS 0.6 artifacts. I suppose this is from JDK 8 and 11 and the one with ScalaJS 1.0.0-M8 is yet another build.

@szeiger
Copy link
Contributor

szeiger commented Sep 2, 2019

Everything dropped.

julienrf added a commit that referenced this pull request Sep 3, 2019
We previously run the CI tasks on the root module, which aggregates
both the JS and JVM modules. This resulted in wasting CPU and
duplicating releases on Sonatype (see #43 (comment))
julienrf added a commit that referenced this pull request Sep 3, 2019
We previously run the CI tasks on the root module, which aggregates
both the JS and JVM modules. This resulted in wasting CPU and
duplicating releases on Sonatype (see #43 (comment))
julienrf added a commit that referenced this pull request Sep 3, 2019
We previously run the CI tasks on the root module, which aggregates
both the JS and JVM modules. This resulted in wasting CPU and
duplicating releases on Sonatype (see #43 (comment))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants