Migrate scripted tests for sbt bridge from zinc repo [ci: last-only] #10554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrytz
commented
Sep 22, 2023
dwijnand
approved these changes
Sep 25, 2023
SethTisue
added
the
internal
lrytz
changed the title
lrytz
force-pushed
the
bridge-tests
branch
2 times, most recently
from
c70cd1b
to
ebc72cf
Compare
lrytz
force-pushed
the
bridge-tests
branch
4 times, most recently
from
be90719
to
1625c60
Compare
|
This is done now, modulo deciding how to run the tests. @SethTisue see my comments in the PR description. What do you think? |
|
Managed to get |
SethTisue
approved these changes
Nov 13, 2023
|
👍 will do |
Copied and adapted from lampepfl/dotty
- use scriptedBatchExecution and scriptedParallelInstances - set scala version in tests - implement shared settings - delete unrelated tests - adjust tests for fullName until PR 10542 is merged - adjust test to hard-coded max filename length of 240, it was 255 on 2.12 (in the zinc repo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build changes copied and adapted from lampepfl/dotty. Tests copied and adapted from sbt/zinc.
To Do
source-dependencies/patMat-scope: after first change, compilation only seems to compile changed file. Existing ticket: IncOptions.useOptimizedSealed is broken on 2.13 sbt/zinc#1229source-dependencies/empty-package: after settingwithRecompileAllFractionto 1.0 this started failing. Old issue, logged at Missing invalidation when deleting source file sbt/zinc#1268checkMainClasses,checkIterations,checkWarnings,checkRecompilationscheckDependenciescheckClasses,checkProductscheckNoClassFiles,checkProductsExistscheckNameExistsInClass, re-enable tests that were disabled in the corresponding commit (one of this PR)figure out when to run the scripted tests in CIdonescriptedtests but rather has its own re-implementation of the a "scripted" test framework.scriptedBatchExecution := truewould make them run much faster, however there's cross-talk between tests that makes some of them fail (e.g., recompilation counts don't start at 1). In dotty some such issues were adressed in https://github.com/lampepfl/dotty/pull/10498/commits, but I'd prefer to keep that complexity out.> setup; reloadto include the shared settings) doesn't seem to affect performance too much (tested by copying the shared sbt file to each test directory).