Re-architecture quote pickling #12540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
8 times, most recently
from
d35cb27
to
a3f0700
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
3 times, most recently
from
345af46
to
1039b5b
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
3 times, most recently
from
216e1b8
to
8d634fe
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
4 times, most recently
from
3e979f5
to
fc1bf94
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
fc1bf94
to
e9bad53
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
484ad44
to
b25ddcf
Compare
6 tasks
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
2 times, most recently
from
39e2c88
to
11cd4c4
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
2 times, most recently
from
11cd4c4
to
70ddaa6
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
044fdab
to
5ee38b9
Compare
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/12540/ to see the changes. Benchmarks is based on merging with main (4c7ec9b) |
|
test performance with #quotes please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/12540/ to see the changes. Benchmarks is based on merging with main (4c7ec9b) |
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
2 times, most recently
from
3c2ae12
to
b9a5448
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
b9a5448
to
0cfea3d
Compare
|
I have just filed related issue 🙏 |
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
0cfea3d
to
11062f7
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
11062f7
to
996e266
Compare
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
2 times, most recently
from
336a00f
to
0683579
Compare
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the `Splicer` phase and the result of the transformation can be `-Ycheck`ed. Now, the `PickleQuotes` phase only needs to extract the contents of the holes, pickle the quote and put them into a call to `unpickleExprV2`/`unpickleTypeV2`. We add `unpickleExprV2` to support some optimization in the encoding of the pickled quote. Namely we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changing `unpickleExpr` the current compiler will be able to handle the old encoding in binaries compiled with older compilers. The `unpickleTypeV2` is just a version of `unpickleType` that does not take the `termHole` parameter which is always `null`. With `-Yscala-relese` 3.0 or 3.1, the compiler will generate calls to the old `unpickleExpr`/`unpickleType`. Fixes scala#8100 Fixes scala#12440 Fixes scala#13563 Fixes scala#14337 Fixes scala#14373 Closes scala#13732
nicolasstucki
force-pushed
the
rearchitecture-quote-splitting
branch
from
0683579
to
ca01392
Compare
|
Finally, we are able to merge this PR. It needs a last review to check that nothing unwanted happened when rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the logic that creates holes in quotes from the logic that pickles the quotes. Holes are created in the
Splicerphase and the result of the transformation can be-Ychecked. Now, thePickleQuotesphase only needs to extract the contents of the holes, pickle the quote and put them into a call tounpickleExprV2/unpickleTypeV2. See documentation inPickleQuotesandSplicer.We add
unpickleExprV2/unpickleTypeV2to support some optimization in the encoding of the pickled quote. Namely, we removed an unnecessary lambda from the arguments of the hole passed into the contents of the hole. By not changingunpickleExpr/unpickleTypethe current compiler will be able to handle the old encoding in binaries compiled with older compilers.Fixes #8100
Fixes #12440
Fixes #13563
Fixes #13732
Fixes #14337
Fixes #14373