-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for -scala-output-version
flag
#15146
Remove support for -scala-output-version
flag
#15146
Conversation
should this be milestoned for 3.2.0-RC1? |
4eccd16
to
0a900f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the report from the script that checks links stability:
Testing links stability in documentation
1990,1992c1990
< ./docs/reference/language-versions/binary-compatibility.html
< ./docs/reference/language-versions/index.html
< ./docs/reference/language-versions/source-compatibility.html
---
> ./docs/reference/language-versions.html
So basically, no pages are lost besides these that were added for -scala-output-version
please could we keep these pages, only some of the information in Edit: they are now kept, thanks! |
Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
144dade
to
d79602a
Compare
@bishabosha @julienrf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the changes that impact the reference documentation.
@smarter @sjrd |
No that will have no impact. The references to the annotation would only be found in the libraries that did define the annotation, given that it was private. And even then, failing to resolve an annotation in existing binaries is not a hard error in the compiler. |
Can I ask what's going on with this flag? It's being removed just after being renamed in #14606, and after work to support has begun in various projects, see e.g. com-lihaoyi/mill#1764 and sbt/sbt#6814. |
@DavidGregory084 The flag was experimental and supported only in one milestone release of SBT. After thoroughly discussing it, we have realized that not only will it be hard to maintain, but also it can be detrimental to the ecosystem. Therefore, we have removed it. Our communication about removing the flag and our plans for long-term compatibility for Scala 3 is in the public review phase after a few rounds of internal feedback from people from EPFL, ScalaCenter, and VirtusLab. You can find it here. I hope it will be published at the very beginning of the following week. |
Thanks @Kordyjan I will have a read! |
The blog post was published at https://www.scala-lang.org/blog/2022/08/17/long-term-compatibility-plans.html |
No description provided.