Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non-static macro implementation error message #18405

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Improve non-static macro implementation error message #18405

merged 2 commits into from
Aug 17, 2023

Conversation

nicolasstucki
Copy link
Contributor

If non-static inline accessor is generated we do not we can tell the user why they cannot access the macro implementation this way.

Currently we do not have a clean way to fix this code, but in the future SIP-58 would introduce a way to not generate this accessor.

Fixes #15413

@nicolasstucki
Improve non-static macro implementation error message
f1db208 
If non-static inline accessor is generated we do not we can tell the
user why they cannot access the macro implementation this way.

Currently we do not have a clean way to fix this code, but in the future [SIP-58](scala/improvement-proposals#58)
would introduce a way to not generate this accessor.

Fixes scala#15413
@nicolasstucki nicolasstucki added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Aug 16, 2023
@nicolasstucki nicolasstucki self-assigned this Aug 16, 2023
@nicolasstucki nicolasstucki marked this pull request as ready for review August 17, 2023 07:49
@nicolasstucki nicolasstucki assigned jchyb and unassigned nicolasstucki Aug 17, 2023
jchyb
jchyb approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@jchyb jchyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Found only a typo (unsure if worth it to retest just for that)

@nicolasstucki @jchyb
Update compiler/src/dotty/tools/dotc/transform/Splicer.scala
546ecf9 
Co-authored-by: Jan Chyb <48855024+jchyb@users.noreply.github.com>
@nicolasstucki nicolasstucki merged commit 473cf25 into scala:main Aug 17, 2023
16 checks passed
@nicolasstucki nicolasstucki deleted the fix-15413 branch August 17, 2023 19:37
@Kordyjan Kordyjan removed the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 10, 2023
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 19, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 20, 2024
@WojciechMazur
Backport "Improve non-static macro implementation error message" to L…
2bf9c12 
…TS (#20595)

Backports #18405 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchyb jchyb jchyb approved these changes

Assignees

@jchyb jchyb

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Macro in class with private implementation from companion object
3 participants
@nicolasstucki @jchyb @Kordyjan