Avoid some intermediate Lists
#18572
Conversation
lolgab
force-pushed
the
avoid-plusplus-concatenate-lists
branch
from
62f6102
to
b2feafe
Compare
| @@ -2132,7 +2132,7 @@ class Definitions { | |||
| if (!isInitialized) { | |||
| // force initialization of every symbol that is synthesized or hijacked by the compiler | |||
| val forced = | |||
| syntheticCoreClasses ++ syntheticCoreMethods ++ ScalaValueClasses() :+ JavaEnumClass | |||
| syntheticCoreClasses ::: syntheticCoreMethods ++ ScalaValueClasses() :+ JavaEnumClass | |||
There was a problem hiding this comment.
This one is a bit strange. Maybe we could force them in a simpler way.
There was a problem hiding this comment.
Oh, I mechanically edited the code without realizing what it was used for.
I changed it to just reference the lists.
ScalaValueClasses() doesn't need to be initialized since it's not a lazy val, so I removed it. Let me know if I'm wrong.
989c961
|
I don't think we should bother with this. List.++ calls directly calls concat, which is overridden in List to match the suffix (the argument) to List and then call :::. So we're removing that overhead, which is constant, so not worth it. |
|
Oh, it goes through |
Co-authored-by: Nicolas Stucki <nicolas.stucki@gmail.com>
lolgab
force-pushed
the
avoid-plusplus-concatenate-lists
branch
from
bf09c1e
to
c3377d4
Compare
lolgab
changed the title
::: instead of ++ to concatenate ListsLists
|
How about replacing usage of |
|
I dropped the change from |
The call to `apply` perform side effects that need to be executed
Backports #18572 to the LTS branch. PR submitted by the release tooling. [skip ci]
Backports #18572 to the LTS branch. PR submitted by the release tooling. [skip ci]
No description provided.