Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error message when accessing private members #18690

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Better error message when accessing private members #18690

merged 2 commits into from
Oct 17, 2023

Conversation

nicolasstucki
Copy link
Contributor

Fixes #18686

bishabosha
bishabosha reviewed Oct 17, 2023
View reviewed changes
tests/neg/i18686c.check
8 | foo.foo // error
| ^^^^^^^
|method foo cannot be accessed as a member of (foo² : Bar.Foo) from the top-level definitions in package <empty>.
| protected[Bar] method foo can only be accessed from object Bar, or class Foo in object Bar or one of its subclasses.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@nicolasstucki nicolasstucki marked this pull request as ready for review October 17, 2023 10:09
bishabosha
bishabosha approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@bishabosha bishabosha merged commit 36a9940 into scala:main Oct 17, 2023
15 checks passed
@bishabosha bishabosha deleted the fix-18686 branch October 17, 2023 13:52
@Kordyjan Kordyjan added this to the 3.4.0 milestone Dec 20, 2023
@WojciechMazur WojciechMazur mentioned this pull request Jun 21, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jun 22, 2024
@WojciechMazur
Backport "Better error message when accessing private members" to LTS (…
332a486 
…#20718)

Backports #18690 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

Better error message when accessing private members
3 participants
@nicolasstucki @bishabosha @Kordyjan