Homogenize TASTy printer formatting #19139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bishabosha This is a change that was in #19106 but not yet in #19105 |
bishabosha
reviewed
Dec 1, 2023
| @@ -258,10 +258,10 @@ class TastyPrinter(bytes: Array[Byte]) { | |||
| import reader.* | |||
| sb.append(s" ${reader.endAddr.index - reader.currentAddr.index}") | |||
There was a problem hiding this comment.
this should be removed - currently it prints something like 2Attributes (2 bytes, starting from 602):
Suggested change
| sb.append(s" ${reader.endAddr.index - reader.currentAddr.index}") |
nicolasstucki
force-pushed
the
fix-tasty-printer-attibute-section
branch
from
f868929
to
5add9b7
Compare
|
@bishabosha I also added a small optimization that also simplifies the code. |
|
maybe you could add #19105 (comment) here |
bishabosha
approved these changes
Dec 1, 2023
WojciechMazur
added a commit
that referenced
this pull request
Jun 26, 2024
Backports #19139 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.