Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to verify that crash is fixed elsewhere. Fixes #19328 #19329

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

raquo
Copy link
Contributor

@raquo raquo commented Dec 23, 2023

Adding tests for crash reproduction #19328 that I reported, that was already fixed in nightly.

I added the pos ones just in case, as protection against potential regressions. So far I managed to reproduce the crash only when the implicit was missing, as in neg tests. I can remove the pos tests if you think these are excessive.

I ran only my own tests locally, they passed.

Fixes #19328

cc @soronpo

@som-snytt
Copy link
Contributor

Probably only neg tests are required, as it's incurred by reporting.

But you could add the tiny test for #19022 and get another ticket to your credit.

@raquo
Copy link
Contributor Author

raquo commented Dec 23, 2023

Ok I removed the pos tests.

Unfortunately I can't reproduce the #19022 crash with Scala 3.3.1. It doesn't crash with the latest scala cli, sbt, or intellij for me. So I doubt that adding the snippet in that ticket as a test would actually trigger the condition that needs testing. The ticket implies that some compiler flags are needed for reproduction, but I'm not sure which ones. I tried -Wconf:v in scala cli, still no crash for me.

@nicolasstucki nicolasstucki merged commit a3d3cf8 into scala:main Feb 1, 2024
19 checks passed
@Kordyjan Kordyjan added this to the 3.4.1 milestone Feb 14, 2024
WojciechMazur added a commit that referenced this pull request Jul 1, 2024
…9328" to LTS (#20875)

Backports #19329 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants