Add tests to verify that crash is fixed elsewhere. Fixes #19328 #19329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tests for crash reproduction #19328 that I reported, that was already fixed in nightly.
I added the
pos
ones just in case, as protection against potential regressions. So far I managed to reproduce the crash only when the implicit was missing, as inneg
tests. I can remove thepos
tests if you think these are excessive.I ran only my own tests locally, they passed.
Fixes #19328
cc @soronpo