[regression] Publish nightly releases and releases using Java 8 #19722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
Feb 17, 2024
| @@ -723,6 +723,8 @@ jobs: | |||
| SONATYPE_USER: ${{ secrets.SONATYPE_USER_ORGSCALALANG }} | |||
|
|
|||
| steps: | |||
| - name: Set JDK 8 as default | |||
There was a problem hiding this comment.
If we don't explicitly set the version, CI will use Java 21
| - name: Set JDK 17 as default | ||
| run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH | ||
| - name: Set JDK 8 as default | ||
| run: echo "/usr/lib/jvm/java-8-openjdk-amd64/bin" >> $GITHUB_PATH |
There was a problem hiding this comment.
Just for making the build future-proof, we should add explicit -source/-release/-target flags to JDK to always emit JDK 8 bytecode and use only JDK API available in that version.
Same issue might be also present in normal releases
There was a problem hiding this comment.
I think this would have to be set in SBT, not in the CI configuration. The best we can do from the CI point of view is switch the default Java version.
|
CI failure is similar to #18344. Restarting the CI might fix it (See #19535) |
WojciechMazur
approved these changes
Feb 19, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Jul 1, 2024
WojciechMazur
pushed a commit
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #19721
[test_java8]