Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore pre-3.3.2 behavior of inline implicit def #19877

Merged
merged 1 commit into from
Mar 5, 2024

Commits on Mar 5, 2024

  1. Restore pre-3.3.2 behavior of inline implicit def

    `inline implicit def` is not really a supported feature since it combines Scala
    3's `inline` with Scala 2's `implicit` where the latter should eventually be
    deprecated. This however didn't prevent at least one project from using this
    combination in a way that was broken by scala#18249, see scala#19862 for the details.
    
    The issue is that when definining:
    
        implicit def foo(x: A): B = ...
    
    Then `foo` is a valid implicit search candidate when looking up an implicit
    `Function1[A, B]`. However, before scala#18249 if instead we wrote:
    
        inline implicit def foo(x: A): B = ...
    
    Then `foo` would be considered as an implicit search candidate but discarded
    because eta-expansion was disabled.
    
    There is no particular reason for `inline implicit def` to behave differently
    from `implicit def` here, but since `implicit def` is a legacy feature and since
    Scala 3.3 is an LTS release, we choose to restore the pre-scala#18249 behavior for
    compatibility reasons.
    
    Fixes scala#19862.
    smarter committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    af69895 View commit details
    Browse the repository at this point in the history