Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sbt 1.10.5 (was 1.9.9) #20157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

sbt 1.10.5 (was 1.9.9) #20157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ RUN apt-get update && \
# Install sbt
ENV SBT_HOME /usr/local/sbt
ENV PATH ${SBT_HOME}/bin:${PATH}
ENV SBT_VERSION 1.9.0
ENV SBT_VERSION 1.10.5
RUN curl -sL "https://github.com/sbt/sbt/releases/download/v$SBT_VERSION/sbt-$SBT_VERSION.tgz" | gunzip | tar -x -C /usr/local
2 changes: 1 addition & 1 deletion community-build/community-projects/fastparse
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this changes necessary to be included in this PR (I doubt) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is needed or the community build fails. there is some discussion with Wojciech about it above. I had to upgrade the project from Scala 2.13.0 to 2.13.15.

Submodule fastparse updated 3 files
+1 −1 build.sbt
+1 −1 project/build.properties
+4 −3 scalaparse/test/src-jvm/scalaparse/ScalacParser.scala
2 changes: 1 addition & 1 deletion community-build/src/scala/dotty/communitybuild/projects.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ final case class SbtCommunityProject(
case Some(ivyHome) => List(s"-Dsbt.ivy.home=$ivyHome")
case _ => Nil
extraSbtArgs ++ sbtProps ++ List(
"-sbt-version", "1.9.7",
"-sbt-version", "1.10.5",
"-Dsbt.supershell=false",
s"-Ddotty.communitybuild.dir=$communitybuildDir",
s"--addPluginSbtFile=$sbtPluginFilePath"
Expand Down
2 changes: 1 addition & 1 deletion project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@ object Dependencies {
"com.vladsch.flexmark" % "flexmark-ext-yaml-front-matter" % flexmarkVersion,
)

val compilerInterface = "org.scala-sbt" % "compiler-interface" % "1.9.6"
val compilerInterface = "org.scala-sbt" % "compiler-interface" % "1.10.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not 1.10.5 and not 1.10.6 here ?

Copy link
Member Author

@SethTisue SethTisue Nov 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's intentional. 1.10.4 is the newest version. there isn't always a new compiler-interface for every new sbt version, as per https://github.com/sbt/zinc/releases/

}
2 changes: 1 addition & 1 deletion project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.9.9
sbt.version=1.10.5
2 changes: 1 addition & 1 deletion tests/cmdTest-sbt-tests/sourcepath-with-inline-api-hash/project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.9.7
sbt.version=1.10.5
2 changes: 1 addition & 1 deletion tests/cmdTest-sbt-tests/sourcepath-with-inline/project/build.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
sbt.version=1.9.7
sbt.version=1.10.5
Loading