Fix #20287: Add flexible types to Quotes library #20293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
previously requested changes
Apr 29, 2024
|
Hi @nicolasstucki, do you have any idea why the extractor for |
noti0na1
added
the
needs-minor-release
|
This should probably be included in 3.5 as it is a part of #18112. Specifically, the changes in the TASTy format require this change in the reflection API. |
|
The core meeting decided to take this PR in on 3.5.0. |
jchyb
approved these changes
May 6, 2024
jchyb
dismissed
nicolasstucki’s stale review
Nicolas is unavailable and all of the changes and concerns raised by him were resolved.
hamzaremmal
approved these changes
May 6, 2024
| ConstantType(StringConstant("hello")) | ||
|
|
||
| Inlined(None, Nil, Apply(Select(Literal(StringConstant("world")), "trim"), Nil)) | ||
| FlexibleType(TypeRef(ThisType(TypeRef(NoPrefix(), "lang")), "String")) |
There was a problem hiding this comment.
Mmmmh, I'm wondering why we don't have the java prefix here for java.lang.String.
We do have it for the second type below 🤔
There was a problem hiding this comment.
I guess because it is from a Java method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #20287
To fix the missing case, we have to add flexible types to
Quoteslibrary.