Commits on Jul 2, 2024

1. Restore pre-3.3.2 behavior of inline implicit def …

   `inline implicit def` is not really a supported feature since it combines Scala
   3's `inline` with Scala 2's `implicit` where the latter should eventually be
   deprecated. This however didn't prevent at least one project from using this
   combination in a way that was broken by #18249, see #19862 for the details.
   
   The issue is that when definining:
   
       implicit def foo(x: A): B = ...
   
   Then `foo` is a valid implicit search candidate when looking up an implicit
   `Function1[A, B]`. However, before #18249 if instead we wrote:
   
       inline implicit def foo(x: A): B = ...
   
   Then `foo` would be considered as an implicit search candidate but discarded
   because eta-expansion was disabled.
   
   There is no particular reason for `inline implicit def` to behave differently
   from `implicit def` here, but since `implicit def` is a legacy feature and since
   Scala 3.3 is an LTS release, we choose to restore the pre-#18249 behavior for
   compatibility reasons.
   
   Fixes #19862.
   
   [Cherry-picked af69895]

   

   smarter authored and WojciechMazur committed Jul 2, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for bfcdef8
   • Browse repository at this point

   Copy the full SHA

   bfcdef8 View commit details

   Browse the repository at this point in the history