Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport "Avoid stacked thisCall contexts" to LTS #21130

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Backport "Avoid stacked thisCall contexts" to LTS #21130

merged 1 commit into from
Jul 9, 2024

Commits on Jul 8, 2024

  1. Avoid stacked thisCall contexts 

    AddImplicitArgs can recursively add several implicit parameter lists.
We need to make sure we don't perform a thisCallContext search in another
thisCall context in this case.

Fixes #20483

The original code would back out further and further in the context chain for every
implicit parameter section on the secondary constructor. Eventually (in this case
after 3 times) bad things happen.

[Cherry-picked 2e4a070][modified]
    @WojciechMazur
    WojciechMazur committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    cfb98d9 View commit details
    Browse the repository at this point in the history