Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Upgrade Scala 2 to 2.13.14 (was 2.13.12)" to LTS #21156

Merged
merged 6 commits into from
Jul 10, 2024

Conversation

WojciechMazur
Copy link
Contributor

Backports #20902 to the LTS branch.

PR submitted by the release tooling.

@WojciechMazur
Copy link
Contributor Author

Blocked by Scala.js compiler plugin.
We should not upgrade Scala.js (1.12) in the LTS to a minimal version cross-published for Scala 2.13.14 (1.15) as it would be a binary incompatible change introduced in the patch release. For that reason we've rejected backports of #20273 and #20294.
Requires either:

  • cross-publishing Scala.js 1.12 compiler plugin for the whole lifetime of the Scala 3.3 LTS series
  • decision of the Scala compiler core team to allow upgrading the Scala.js in the patch releases of LTS series

@sjrd @gzm0 @Kordyjan

@WojciechMazur
Copy link
Contributor Author

I think that setting the Scala 2 version used in the sbt Scala.js-specific scripted tests to 2.13.13 should do the job without requiring any changes from the Scala.js. Sorry for the alarm here.

Base automatically changed from lts-20557 to lts-3.3 July 10, 2024 14:24
@WojciechMazur
Copy link
Contributor Author

No regressions detected in the community build up to lts-20902.

Reference

@WojciechMazur WojciechMazur merged commit 7eec9eb into lts-3.3 Jul 10, 2024
19 checks passed
@WojciechMazur WojciechMazur deleted the lts-20902 branch July 10, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants