-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add origin filter to WConf, DeprecationWarning #21404
Conversation
We should add documentation here https://github.com/scala/scala3/blob/3.5.0/compiler/src/dotty/tools/dotc/config/ScalaSettings.scala#L251 (After running Looks good otherwise! |
Also the summary counts 4
but under
|
It has taken me more than a few minutes on
|
77d194f
to
929e7eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good!
I didn't add a |
The
origin
parameter todeprecationWarning
is optional; the parameter toDeprecationWarning
is not.The
origin
of a deprecation is simply the deprecated symbol. The full name is matched by the regex specified by-Wconf
.The other important use case is the
origin
of an unused element, in particular, the selector which causes an "unused import" warning. That use case will be supported in a follow-up PR, and should work as in Scala 2.Fixes #17538