Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend computes line number from source of position #21763

Merged
merged 3 commits into from
Oct 16, 2024
Merged

backend computes line number from source of position #21763

merged 3 commits into from
Oct 16, 2024

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Oct 14, 2024 •
edited
Loading

fixes #21762

This makes it possible to implement line number correction for Mill build files under Scala 3

@bishabosha bishabosha mentioned this pull request Oct 14, 2024
Open
20 tasks
@bishabosha
Copy link
Member Author

bishabosha commented Oct 14, 2024 •
edited
Loading

we could backport this also to 3.5.x/3.6.x series (it doesn't introduce any new methods)

@smarter smarter merged commit 8431d84 into scala:main Oct 16, 2024
28 checks passed
@smarter smarter deleted the fix-backend-code-linenumber branch October 16, 2024 10:42
@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Oct 16, 2024
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Oct 16, 2024
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 16, 2024
@WojciechMazur WojciechMazur mentioned this pull request Oct 16, 2024
Merged
WojciechMazur added a commit that referenced this pull request Oct 17, 2024
@WojciechMazur @bishabosha
Backport "backend computes line number from source of position" to 3.…
3f5ba86 
…6.0 (#21793)

Backports #21763 to 3.6.0-RC1

---------

Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal approved these changes

@smarter smarter smarter approved these changes

@sjrd sjrd Awaiting requested review from sjrd

Assignees
No one assigned
Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

Backend line-number computation doesn't account for underlying SourceFiles.
4 participants
@bishabosha @smarter @hamzaremmal @WojciechMazur