-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch files to execute Dotty commands on Windows #5444
Conversation
Thanks a lot @michelou ! I created a test here: lampepfl/packtest#18 It seems there is some error when running the batch files. As I've very little experience with batch scripts. Could you please have a look? Thanks a lot. https://ci.appveyor.com/project/liufengyun/packtest-s6xq2/builds/20551431/job/mdakdmt9m9pp6jlr |
Thanks @michelou , the CI now is green: lampepfl/packtest#18 |
project/scripts/build.bat
Outdated
echo arch[ives]-only generate ONLY gz/zip archives | ||
echo boot[strap]-only generate ONLY compiler bootstrap | ||
echo compile-only generate ONLY compiler 1st stage | ||
echo doc[umentation]-only] generate ONLY documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation to have both tests and some utility in the same batch?
project/scripts/build.bat
Outdated
@@ -0,0 +1,458 @@ | |||
@echo off | |||
setlocal enabledelayedexpansion | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern with this file is that we need CI for windows. Related issue: #4588
We can try to integrate appveyor
and run build.bat
, but NOT the whole test set.
I wrote |
I assume your configuration file |
@michelou Thanks for the clarification. My only concern is about maintainability -- if we don't run |
@liufengyun Note that apparently the latest version of drone supports Windows, and we'd like to add Windows to our CI eventually. |
Batch files are still available from my project |
dist\bin\
will be copied unchanged to the gz/zip archives (seesbt dist-bootstrapped/packArchive
).Batch files added toproject\scripts\
(ie.build.bat
,cmdTests.bat
andbootstrapCmdTests.bat
) are adapted from.drone.yml
(executed on the Dotty CI server) and can generate the documentation and the gz/zip archives (depending on bootstrap and tests results).NB. Point 1 is ready to be tested on a Windows machine,
but point 2 requires my changes inPoints 1 and 2 have been tested on a Windows machine and are used in PR #5531.compiler\src\*.scala
andcompiler\test\*.scala
to be committed in a new branch (and submitted as a separate PR).