sbt 1.4.0

[bjaglin]

The second commit works around sbt/sbt#5647, which can be observed when the client uses sbt 1.4.0 (independently of the version we build with/against here) and defines scalafixCaching.

[bjaglin]

sbt-scalafix/src/main/scala/scalafix/sbt/ScalafixPlugin.scala

Line 363 in 5238ad7

val cachingRequested = scalafixCaching.or(scalafixOnCompile).value

is not picked up by sbt inspect (as of sbt 1.4.0), so this makes a dummy lookup for the sake of materializing the usage

 sbt:sbt-scalafix> inspect actual scalafixCaching
 [info] Setting: Boolean = true
 [info] Description:
 [info] 	Cache scalafix invocations (off by default, on if scalafixOnCompile := true).
 [info] Provided by:
 [info] 	ProjectRef(uri("file:/home/bjaglin/git/projects/sbt-scalafix/"), "sbt-scalafix") / scalafixCaching
 [info] Defined at:
 [info] 	/home/bjaglin/git/projects/sbt-scalafix/build.sbt:48
+[info] Reverse dependencies:
+[info] 	Test / scalafix
+[info] 	Compile / scalafix
 [info] Delegates:
 [info] 	scalafixCaching
 [info] 	ThisBuild / scalafixCaching
 [info] 	Global / scalafixCaching

[adpi2]

This seems legitimate.

I wonder if this workaround is still needed though:

sbt-scalafix/src/main/scala/scalafix/sbt/ScalafixPlugin.scala

Lines 324 to 328 in 5238ad7

	// workaround https://github.com/sbt/sbt/issues/3572 by invoking directly what Def.inputTaskDyn would via macro
	InputTask
	.createDyn(InputTask.initParserAsInput(scalafixCompletions(_.parser)))(
	Def.task(shellArgs => scalafixTask(shellArgs, config))
	)

The task graph would be simplified with a single level of dynamicity instead of two.

[bjaglin]

I wonder if this workaround is still needed though:

Unfortunately, even if it was fixed in 1.4.0 (I don't think it is), we would still need to keep the hack for compatibility with older 1.x clients. The first commit bumps the version of sbt for this build, but the sbt API build against and the runtime we run scripted with remains unchanged, see:

sbt-scalafix/build.sbt

Lines 53 to 66 in 5238ad7

	sbtVersion in pluginCrossBuild := {
	// keep this as low as possible to avoid running into binary incompatibility such as https://github.com/sbt/sbt/issues/5049
	scalaBinaryVersion.value match {
	case "2.10" => "0.13.17"
	case "2.12" => "1.2.1"
	}
	}
	scriptedSbt := {
	// first releases that can build 2.13 (as they bring a Zinc version with a compiler-bridge published for 2.13)
	scalaBinaryVersion.value match {
	case "2.10" => "0.13.18"
	case "2.12" => "1.2.7"
	}
	}

.