Skip validation if there are no sources to fix. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olafurpg
force-pushed
the
validate-root
branch
from
7dd5294 to
3241b4f
Compare
Previously, the semanticdb-scalac and scalacOptions validation ran for empty root projects with no sources, failing the build when running scalafix from the root project. Since there are no sources to fix we should not run any validation.
olafurpg
force-pushed
the
validate-root
branch
from
3241b4f to
4a7f4a3
Compare
olafurpg
commented
Sep 21, 2018
| ) | ||
| ) | ||
|
|
||
| lazy val root = project |
There was a problem hiding this comment.
@abdheshkumar I was able to reproduce the bug with this build.sbt, I got the following error before the fix
[info] [error] (Compile / scalafix) scalafix.sbt.InvalidArgument: 2 errors
[info] [error] [E1] The semanticdb-scalac compiler plugin is required to run semantic rules like RemoveUnused.
[info] [error] To fix this problem for this sbt shell session, run `scalafixEnable` and try again.
[info] [error] To fix this problem permanently for your build, add the following settings to build.sbt:
[info] [error] addCompilerPlugin(scalafixSemanticdb)
[info] [error] scalacOptions += "-Yrangepos"
[info] [error]
[info] [error] [E2] The Scala compiler option "-Ywarn-unused" is required to use RemoveUnused.
[info] [error] To fix this problem, update your build to use at least one Scala compiler
[info] [error] option that starts with "-Ywarn-unused"
After the fix scalafix runs successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the semanticdb-scalac and scalacOptions validation ran for
empty root projects with no sources, failing the build when running
scalafix from the root project. Since there are no sources to fix we
should not run any validation.
Fixes scalacenter/scalafix#884