-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More complex builds for github:org/repo
rewrites
#280
Comments
Yeah, let's not implement our own build tool 👍 |
After more thinking, here is what I think strikes a nice balance between supporting more complex builds without reinventing the wheel
This scheme scales nicely for both migration rewrites with a This allows rules like This approach will also scale nicely for non-GitHub projects, since it's based on git. |
👍 I would clone it with |
I suggest that we close this ticket with "Please publish your rule to maven central". Published rules have the same UX as built-in scalafix rules. Rules that want to enjoy the benefits of being compileable from source will need to meet the criteria
|
Currently, github:org/repo rewrites need to fit in a single file. It would be nice if scalafix supported more complex builds to accommodate
There are several ways to achieve this
scalafix/rewrites
projects from source.sbt rewrites/fullClasspath
will give the classpath and scalafix won't have to compile sources itself.I'm personally leaning towards the second option. I don't have much experience with using sbt programmatically or with sbt source dependencies but if it works then it's a very powerful solution. Also, this solution would give incremental and cached compilation.
The text was updated successfully, but these errors were encountered: