Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libs #1106

Merged
merged 7 commits into from
May 3, 2020
Merged

Update libs #1106

merged 7 commits into from
May 3, 2020

Conversation

giabao
Copy link
Contributor

@giabao giabao commented Apr 24, 2020

Don't see @scala-steward update those libs, so I create this PR 😄

olafurpg
olafurpg suggested changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! We need to keep ScalaTest unchanged. Otherwise LGTM 👍

project/Dependencies.scala Outdated Show resolved Hide resolved
olafurpg
olafurpg approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thank you!

@olafurpg olafurpg merged commit facfc1f into scalacenter:master May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@giabao @olafurpg