align behavior with semanticdb-scalac: last arg wins #1116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #1110, as failure to look up the target root triggers the presentation compiler, with a version that might not match the bytecode injected (see #998).
The
SemanticDBPlugin
from sbt 1.3.x duplicates thetargetroot
option onTest
(or any configuration that extends one where scalafix is enabled) via parent configuration delegation.: https://github.com/sbt/sbt/blob/a1b54d027a87654cbc782270872afc1b4c5a8852/main/src/main/scala/sbt/plugins/SemanticdbPlugin.scala#L42-L45.In that case,
semanticdb-scalac
picks the last: https://github.com/scalameta/scalameta/blob/de206a796c7558f0ceb8bf3a557f3296f0ac34de/semanticdb/scalac/library/src/main/scala/scala/meta/internal/semanticdb/scalac/ConfigOps.scala#L105-L106, while scalafix was picking the first.