Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify syntax of --tool-classpath #1122

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented May 13, 2020

  • I naively assumed a URLClassLoader would require URL(s), and it did work for a while (the file: prefix is supported in java.nio.file.Paths.get()), until my path contained '%' which was not supposed to be escaped
  • Seeing that repeating the argument did not work, I had to look up the source code to figure out the usage of a single, java.ioFile.pathSeparator-separated argument value

* I naively assumed a `URLClassLoader` would require URL(s), and it
  did work for a while (the `file:` prefix is supported in
  java.nio.file.Paths.get()), until my path contained '%' which was
  not supposed to be escaped
* Seeing that repeating the argument did not work, I had to look up
  the source code to figure out the usage of a single,
  java.ioFile.pathSeparator-separated argument value
@bjaglin bjaglin marked this pull request as ready for review May 13, 2020 23:41
@bjaglin bjaglin requested a review from mlachkar May 27, 2020 12:30
@bjaglin bjaglin requested a review from olafurpg June 8, 2020 08:23
@bjaglin
Copy link
Collaborator Author

bjaglin commented Jun 16, 2020

any feedback on this @olafurpg @mlachkar ?

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bjaglin bjaglin merged commit 4bc3d1a into scalacenter:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants