respect -Xlint or -Xlint:unused scalac options in RemoveUnused rule #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taisukeoe
commented
Jun 14, 2020
| ) | ||
| if (!hasWarnUnused) { | ||
| Configured.error( | ||
| s"""|The Scala compiler option "-Ywarn-unused" is required to use RemoveUnused. | ||
| |To fix this problem, update your build to use at least one Scala compiler | ||
| |option that starts with -Ywarn-unused or -Wunused (2.13 only)""".stripMargin | ||
| |option like -Ywarn-unused, -Xlint:unused, or -Wunused (2.13 only).""".stripMargin |
There was a problem hiding this comment.
I didn't add -Xlint to suggestions in the error message since -Xlint is for multi purposes.
taisukeoe
force-pushed
the
respect-xlint-unused
branch
from
630e378 to
555f2d2
Compare
taisukeoe
commented
Jun 14, 2020
| ) | ||
| if (!hasWarnUnused) { | ||
| Configured.error( | ||
| s"""|The Scala compiler option "-Ywarn-unused" is required to use RemoveUnused. | ||
| |To fix this problem, update your build to use at least one Scala compiler | ||
| |option that starts with -Ywarn-unused or -Wunused (2.13 only)""".stripMargin | ||
| |option like -Ywarn-unused, -Xlint:unused (2.12.2 or above), or -Wunused (2.13 only)""".stripMargin |
There was a problem hiding this comment.
Unused warnings by -Xlint or -Xlint:unused are effective since Scala 2.12.2.
scala/bug#10270
scala/scala#5402
So suggesting -Xlint:unused is not relevant in Scala 2.12.1 or lower while Scalafix still supports 2.11 . To be safer, I would clarify which versions are supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PullRequests suppress RemoveUnused configuration error if scalac options contain
-Xlintor-Xlint:unused, both of which generate and add unused diagnostics message string into SemanticDB.Note: There might be discussions at the following point.
-Xlint linting options notation
Currently this PullRequest supports no explicit linting option (just
-Xlint) or only a linting option per a line (-Xlint:unused) for implementation simplicity. IMHO this covers majority of-Xlintusage, as long as I check with "-Xlint" GitHub search.This PR does NOT support multiple linting options together like
-Xlint:unused,constant, wildcard like-Xlint:_, nor unary operator like-Xlint:-constant,_.If we want to support multiple linting options notation or else above, it may need to introduce a simple scalac option parser (or just check in a naive way, like
option.startsWith("-Xlint:") && (option.contains("_") || option.contains("unused")) && !option.contains("-unused")?).