Add support for the 3 last versions of scala for each binary version for rules #1174

mlachkar · 2020-06-22T10:18:13Z

No description provided.

bjaglin

I don't think we should be using ++ here - it should just be the test input that should be built with older versions of the scala compiler (and potentially the semanticdb plugin compiler). The rules themselves should run with the latest version, as we want to test the artifact being published.

bjaglin · 2020-06-22T12:27:33Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

+    val supprtedVersions = compilerVersion
+      .map(int => Set(int - 2, int - 1, int).filter(_ >= 0))
+      .getOrElse(Set())


Suggested change

val supprtedVersions = compilerVersion

.map(int => Set(int - 2, int - 1, int).filter(_ >= 0))

.getOrElse(Set())

val supportedVersions = List.range(compilerVersion-2, compilerVersion).filter(_>=0)

bjaglin · 2020-06-22T12:32:50Z

project/ScalafixBuild.scala

@@ -194,15 +194,27 @@ object ScalafixBuild extends AutoPlugin with GhpagesKeys {
        "unit/test" ::
        "docs/run" ::
        "interfaces/doc" ::
+        s"++$scala213V1" ::


instead of hardcoding the previous versions, you can probably generate the list dynamically and loop over it

I have more tests that fails when testing against more scala Version.
I was thinking about adding a specific test that will test only ExplicitResultType :
+unit/testOnly scalafix.tests.rule.RuleSuite -- -z explicitResult

mlachkar · 2020-06-22T15:10:09Z

If I set scalaVersion for both testsInput and testsOutput to another scalaVersion, it's supposed to verify what we want to test.
The test will look like :

set testsInput/scalaVersion := "2.12.8"
set testsOutput/scalaVersion := "2.12.8"
unit/testOnly scalafix.tests.rule.RuleSuite -- -z explicitResult

But I noticed that it's not failing if it's not within the 3 versions range. The version check uses as the scala version from TestkitProperties.version, which is not the correct one (?)

bjaglin · 2020-06-22T19:26:42Z

The version check uses as the scala version from TestkitProperties.version, which is not the correct one (?)

That sounds a lot like the same problem as #1169 (comment), except that this time it's scalaVersion (and not scalacOptions) that was picked up from the test runner instead of the compiled sources.

mlachkar · 2020-06-23T13:51:50Z

I will check that.

mlachkar · 2020-06-30T16:02:05Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

@@ -19,10 +21,20 @@ final class ExplicitResultTypes(

  def this() = this(ExplicitResultTypesConfig.default, LazyValue.now(None))

-  private def supportedScalaVersion = Properties.versionNumberString
+  private def supportedScalaVersions: List[String] = {


I am not completely satisfied of duplicating this logic. Is there a way to retrieve supportedScalaVersionsForExplicitResultTypeRule from builldInfo

definitely! you should define a specific buildInfo for the rules project in build.sbt - look for stuff with the buildInfo prefix there to see how it works (keys + plugin activation)

bjaglin

A few comments/suggestions to make the testing more maintainable and the error messages (hopefully) more understandable.

bjaglin · 2020-06-30T21:17:09Z

project/ScalafixBuild.scala

+              List(
+                s"""set ThisBuild/scalaVersion := "$k"""",
+                s"""set  testsInput/scalaVersion := "$v"""",
+                s"""set testsOutput/scalaVersion := "$v\"""",


that's not really required as only the source is used for assertion

you mean set testsOutput/scalaVersion := "$v is not required.
The rest is here to verify that the testInput is compiled in a different version from the rule

you mean set testsOutput/scalaVersion := "$v is not required.

yes, that specific line is not required, but the 2 others are indeed!

bjaglin · 2020-06-30T21:22:38Z

project/Dependencies.scala

+  private def supportedScalaVersions(scalaVersion: String): List[String] = {
+    val split = scalaVersion.split('.')
+    val binaryVersion = split.take(2).mkString(".")
+    val compilerVersion = Try(split.last.toInt).toOption
+    val supportedVersions =
+      compilerVersion.map(version => List.range(version - 2, version + 1).filter(_ >= 0)).getOrElse(Nil)
+    supportedVersions.map(v => s"$binaryVersion.$v")
+  }


I think this should be called after what it does, not after what it is used for. What about something like this:

Suggested change

private def supportedScalaVersions(scalaVersion: String): List[String] = {

val split = scalaVersion.split('.')

val binaryVersion = split.take(2).mkString(".")

val compilerVersion = Try(split.last.toInt).toOption

val supportedVersions =

compilerVersion.map(version => List.range(version - 2, version + 1).filter(_ >= 0)).getOrElse(Nil)

supportedVersions.map(v => s"$binaryVersion.$v")

}

private def latestVersions(scalaVersion: String): List[String] = {

val split = scalaVersion.split('.')

val binaryVersion = split.take(2).mkString(".")

val compilerVersion = Try(split.last.toInt).toOption

val latestPatchVersions =

compilerVersion.map(version => List.range(version - 2, version + 1).filter(_ >= 0)).getOrElse(Nil)

latestPatchVersions.map(v => s"$binaryVersion.$v")

}

bjaglin · 2020-06-30T21:32:52Z

project/ScalafixBuild.scala

@@ -212,6 +213,21 @@ object ScalafixBuild extends AutoPlugin with GhpagesKeys {
        s"unit/testOnly -- -l scalafix.internal.tests.utils.SkipWindows" ::
        s
    },
+    commands += Command.command("ci-explicit-result-types-rule") { s =>


Instead of doing a new command that loops through all binary versions, maybe we could patch existing ci-212 & ci-213 commands to run an extra unit/test scalafix.tests.rule.RuleSuite for the N-1 & N-2 versions (since N is already run as part of the unit/test)? I think CI failures there would be clearer to troubleshoot (and everything would be already compiled)

bjaglin · 2020-06-30T21:38:01Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

+    if (config.scalacClasspath.nonEmpty && !supportedScalaVersions.contains(
+        config.scalaVersion
+      )) {
+      val shortScalaVersion =


Suggested change

val shortScalaVersion =

val inputBinaryScalaVersion =

bjaglin · 2020-06-30T21:38:25Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

+      )) {
+      val shortScalaVersion =
+        config.scalaVersion.split(".").take(2).mkString(".")
+      val shortRuleScalaVersion =


Suggested change

val shortRuleScalaVersion =

val runtimeBinaryScalaVersion =

bjaglin · 2020-06-30T21:49:17Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

+        s"Your scalaVersion is ${config.scalaVersion} but the ExplicitResultTypes rule is compiled with ${shortRuleScalaVersion}" +
+          s"and only supports these Scala versions '$supportedScalaVersions'. " +
+          (if (shortScalaVersion == shortRuleScalaVersion)
+             s"To fix this problem, either remove `ExplicitResultTypes` from .scalafix.conf or change the Scala version to be within '$supportedScalaVersions'"
+           else
+             s"To fix this problem, either remove `ExplicitResultTypes` from .scalafix.conf or " +
+               s"specify a `scalafixScalaBinaryVersion` key in your build.sbt equal to  $shortScalaVersion")


For clarity, I think this message could be different depending on whether the binary version matches or not.

inputBinaryScalaVersion == runtimeBinaryScalaVersion

The ExplicitResultTypes rule only supports the exact Scala versions '$supportedScalaVersion' for this binary version. To fix this problem, either remove ExplicitResultTypes from .scalafix.conf or change the Scala version of your build to match one of the supported versions.

($supportedScalaVersion should list the full versions supported for the binary version $inputBinaryScalaVersion)

inputBinaryScalaVersion != runtimeBinaryScalaVersion

The ExplicitResultTypes rule needs to run with the same Scala binary version as the one used to compile target sources ($inputBinaryScalaVersion). To fix this problem, either remove ExplicitResultTypes from .scalafix.conf or make sure the scalafixScalaBinaryVersion setting key matches $inputBinaryScalaVersion.

bjaglin · 2020-06-30T21:54:00Z

project/ScalafixBuild.scala

@@ -67,6 +67,7 @@ object ScalafixBuild extends AutoPlugin with GhpagesKeys {
        "scalameta" -> scalametaV,
        scalaVersion,
        "supportedScalaVersions" -> supportedScalaVersions,
+        "supportedScalaVersionsForExplicitResultTypeRule" -> supportedScalaVersionforExplicitResultRule,


this is the build info of core, I don't think it should know anything about built-in rules

bjaglin · 2020-06-30T21:54:43Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

@@ -19,10 +21,20 @@ final class ExplicitResultTypes(

  def this() = this(ExplicitResultTypesConfig.default, LazyValue.now(None))

-  private def supportedScalaVersion = Properties.versionNumberString
+  private def supportedScalaVersions: List[String] = {


definitely! you should define a specific buildInfo for the rules project in build.sbt - look for stuff with the buildInfo prefix there to see how it works (keys + plugin activation)

bjaglin · 2020-06-30T21:57:38Z

project/Dependencies.scala

@@ -11,6 +13,10 @@ object Dependencies {
  def coursierV = "2.0.0-RC5-6"
  def coursierInterfaceV = "0.0.22"
  val currentScalaVersion = scala213
+  // we support 3 last binary versions of each scala Version, except for 2.11 because semanticdb-scalac_2.11.10 is missing.
+  val supportedScalaVersionforExplicitResultRule =


I think this should not be specific to a single rule - we could test all of them (unit/testOnly scalafix.tests.rule.RuleSuite) against that set of versions (which will only be useful for those that use the presentation compiler, but at least we won't miss cross-testing it when a new one is introduced).

ok, I agree.

mlachkar · 2020-07-01T13:04:17Z

Thanks for your review and comments @bjaglin. I do find the new version way better.

bjaglin

Nice! A few more comments, but they are mostly cosmetic/implementation details that can be addressed later (or not).

bjaglin · 2020-07-01T13:08:29Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

  override def description: String =
    "Inserts type annotations for inferred public members. " +
-      s"Only compatible with Scala $supportedScalaVersion."
+      s"Only compatible with Scala $supportedScalaVersions."


does the toString representation of that map reads well? maybe we should only show the values (and maybe mkstring them) ?

Suggested change

s"Only compatible with Scala $supportedScalaVersions."

s"Only compatible with Scala ${supportedScalaVersions.values.flatten}."

project/ScalafixBuild.scala

bjaglin · 2020-07-01T13:11:39Z

project/ScalafixBuild.scala

+      .flatMap { v =>
+        List(
+          s"""set testsInput/scalaVersion := "$v"""",
+          s"""set testsOutput/scalaVersion := "$v"""",


as discussed in the other thread, this does not need to be (re)-compiled, as only sources are used for assertions

Suggested change

s"""set testsOutput/scalaVersion := "$v"""",

you're right .. forgot to remove it.

project/ScalafixBuild.scala

bjaglin · 2020-07-01T13:34:06Z

build.sbt

@@ -71,13 +71,17 @@ lazy val rules = project
  .in(file("scalafix-rules"))
  .settings(
    moduleName := "scalafix-rules",
+    buildInfoKeys ++= Seq[BuildInfoKey](
+      "supportedScalaVersionforRules" -> supportedScalaVersionforRules


since this is local to the rules module, I don't think the suffix is required for the key

Suggested change

"supportedScalaVersionforRules" -> supportedScalaVersionforRules

"supportedScalaVersions" -> supportedScalaVersionforRules

build.sbt

bjaglin

This (atomic) set of suggestions is a thought/proposal I came up with after our discussion around the filter - maybe it's better to have deal with a list of previously supported versions for the current binary version, explicitly named so?

WDYT? I can probably open a separate PR after this is merged to start the discussion... Also, I forgot to update ExplicitResultTypes.scala in that suggestion set, to reflect the fact that RulesBuildInfo.supportedScalaVersions would be a list rather than a map.

bjaglin · 2020-07-01T22:15:55Z

build.sbt

+    buildInfoKeys ++= Seq[BuildInfoKey](
+      "supportedScalaVersions" -> supportedScalaVersionforRules
+    ),


Suggested change

buildInfoKeys ++= Seq[BuildInfoKey](

"supportedScalaVersions" -> supportedScalaVersionforRules

),

buildInfoKeys ++= Seq[BuildInfoKey](

"supportedScalaVersions" -> scalaVersion.value :: testedPreviousScalaVersions(scalaBinaryVersion.value)

),

bjaglin · 2020-07-01T22:17:35Z

project/Dependencies.scala

+  val supportedScalaVersionforRules =
+    List(scala213, scala212).map(version => version -> latestVersions(version)).toMap ++
+      Map(scala211 -> List(scala211))


Suggested change

val supportedScalaVersionforRules =

List(scala213, scala212).map(version => version -> latestVersions(version)).toMap ++

Map(scala211 -> List(scala211))

val testedPreviousScalaVersions =

List(scala213, scala212).map(version => version -> previousVersions(version)).toMap

bjaglin · 2020-07-01T22:18:11Z

project/Dependencies.scala

+  private def latestVersions(scalaVersion: String): List[String] = {
+    val split = scalaVersion.split('.')
+    val binaryVersion = split.take(2).mkString(".")
+    val compilerVersion = Try(split.last.toInt).toOption
+    val latestPatchVersions =
+      compilerVersion.map(version => List.range(version - 2, version + 1).filter(_ >= 0)).getOrElse(Nil)
+    latestPatchVersions.map(v => s"$binaryVersion.$v")
+  }


Suggested change

private def latestVersions(scalaVersion: String): List[String] = {

val split = scalaVersion.split('.')

val binaryVersion = split.take(2).mkString(".")

val compilerVersion = Try(split.last.toInt).toOption

val latestPatchVersions =

compilerVersion.map(version => List.range(version - 2, version + 1).filter(_ >= 0)).getOrElse(Nil)

latestPatchVersions.map(v => s"$binaryVersion.$v")

}

private def previousVersions(scalaVersion: String): List[String] = {

val split = scalaVersion.split('.')

val binaryVersion = split.take(2).mkString(".")

val compilerVersion = Try(split.last.toInt).toOption

val previousPatchVersions =

compilerVersion.map(version => List.range(version - 2, version).filter(_ >= 0)).getOrElse(Nil)

previousPatchVersions.map(v => s"$binaryVersion.$v")

}

bjaglin · 2020-07-01T22:19:25Z

project/ScalafixBuild.scala

+  private def testRulesFor(scalaVersion: String, state: State): State = {
+    supportedScalaVersionforRules(scalaVersion)
+      .filter(_ != scalaVersion)


Suggested change

private def testRulesFor(scalaVersion: String, state: State): State = {

supportedScalaVersionforRules(scalaVersion)

.filter(_ != scalaVersion)

private def testRulesAgainstPreviousScalaVersions(scalaVersion: String, state: State): State = {

testedPreviousScalaVersions(scalaVersion)

bjaglin · 2020-07-01T22:19:53Z

project/ScalafixBuild.scala

        "unit/test" ::
        "docs/run" ::
        "interfaces/doc" ::
-        s
+        testRulesFor(scala213, s)


Suggested change

testRulesFor(scala213, s)

testRulesAgainstPreviousScalaVersions(scala213, s)

bjaglin · 2020-07-01T22:20:00Z

project/ScalafixBuild.scala

        "unit/test" ::
-        s
+        testRulesFor(scala212, s)


Suggested change

testRulesFor(scala212, s)

testRulesAgainstPreviousScalaVersions(scala212, s)

bjaglin · 2020-07-01T22:20:07Z

project/ScalafixBuild.scala

        "unit/test" ::
-        s
+        testRulesFor(scala211, s)


Suggested change

testRulesFor(scala211, s)

testRulesAgainstPreviousScalaVersions(scala211, s)

bjaglin · 2020-07-01T22:37:23Z

scalafix-rules/src/main/scala/scalafix/internal/rule/ExplicitResultTypes.scala

@@ -18,11 +18,14 @@ final class ExplicitResultTypes(
 ) extends SemanticRule("ExplicitResultTypes") {

  def this() = this(ExplicitResultTypesConfig.default, LazyValue.now(None))
+  val supportedScalaVersions = RulesBuildInfo.supportedScalaVersions
+  val runtimeScalaVersion = RulesBuildInfo.scalaVersion


As far as I remember, I suggested the name runtimeScalaVersion because you were using scala.util.Properties.versionNumberString in an earlier commit of this PR. Now that it's using RulesBuildInfo, I think the right naming would be

Suggested change

val runtimeScalaVersion = RulesBuildInfo.scalaVersion

val compilerScalaVersion = RulesBuildInfo.scalaVersion

In some rare cases, I guess the runtime can differ from that. But from my understanding anyway, this is actually closer to what we want: compare the presentation compiler version brought by scalameta (using the exact same scalaVersion as rules) against the version of scalac used for the input.

Am I getting this right @olafurpg ?

Anyway, this is just naming so it can be tweaked later (maybe in the same PR as the previous set of cosmetic suggestions I had), I just wanted to make sure we were doing/testing the right thing here.

against the version of scalac used for the input

JFYI, there's also scala.tools.nsc.Properties.versionNumberString which is the compiler's version, but it's highly unlikely to vary compared to the standard library version.

it's highly unlikely to vary compared to the standard library version.

I guess that can only happen if the scala version of scalafix-core & scalameta drift, which ~~is rarely the case (https://github.com/scalacenter/scalafix/pull/1179/files bumps both for example)~~ is impossible 😄

$ cs resolve -t ch.epfl.scala::scalafix-rules:0.9.17 Result: └─ ch.epfl.scala:scalafix-rules_2.13:0.9.17 ├─ ch.epfl.scala:scalafix-core_2.13:0.9.17 │ ├─ com.geirsson:metaconfig-typesafe-config_2.13:0.9.10 │ │ ├─ com.geirsson:metaconfig-core_2.13:0.9.10 │ │ │ ├─ com.lihaoyi:pprint_2.13:0.5.9 │ │ │ │ ├─ com.lihaoyi:fansi_2.13:0.2.9 │ │ │ │ │ └─ com.lihaoyi:sourcecode_2.13:0.2.1 │ │ │ │ └─ com.lihaoyi:sourcecode_2.13:0.2.1 │ │ │ ├─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ │ │ ├─ org.scala-lang.modules:scala-collection-compat_2.13:2.1.2 -> 2.1.6 │ │ │ │ └─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ │ │ └─ org.typelevel:paiges-core_2.13:0.3.0 │ │ │ └─ org.scala-lang:scala-library:2.13.0 -> 2.13.2 │ │ ├─ com.typesafe:config:1.2.1 │ │ └─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ ├─ com.googlecode.java-diff-utils:diffutils:1.3.0 │ ├─ org.scala-lang:scala-library:2.13.2 │ ├─ org.scala-lang.modules:scala-collection-compat_2.13:2.1.6 │ │ └─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ └─ org.scalameta:scalameta_2.13:4.3.14 │ ├─ org.scala-lang:scala-library:2.13.2 │ ├─ org.scala-lang:scalap:2.13.2 │ │ └─ org.scala-lang:scala-compiler:2.13.2 │ │ ├─ net.java.dev.jna:jna:5.3.1 │ │ ├─ org.jline:jline:3.14.1 │ │ ├─ org.scala-lang:scala-library:2.13.2 │ │ └─ org.scala-lang:scala-reflect:2.13.2 │ │ └─ org.scala-lang:scala-library:2.13.2 │ └─ org.scalameta:parsers_2.13:4.3.14 │ ├─ org.scala-lang:scala-library:2.13.2 │ └─ org.scalameta:trees_2.13:4.3.14 │ ├─ com.thesamet.scalapb:scalapb-runtime_2.13:0.10.3 │ │ ├─ com.google.protobuf:protobuf-java:3.11.4 │ │ ├─ com.lihaoyi:fastparse_2.13:2.3.0 │ │ │ ├─ com.lihaoyi:geny_2.13:0.6.0 │ │ │ └─ com.lihaoyi:sourcecode_2.13:0.2.1 │ │ ├─ com.thesamet.scalapb:lenses_2.13:0.10.3 │ │ │ ├─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ │ │ └─ org.scala-lang.modules:scala-collection-compat_2.13:2.1.6 │ │ │ └─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ │ ├─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ │ └─ org.scala-lang.modules:scala-collection-compat_2.13:2.1.6 │ │ └─ org.scala-lang:scala-library:2.13.1 -> 2.13.2 │ ├─ org.scala-lang:scala-library:2.13.2 │ ├─ org.scalameta:common_2.13:4.3.14 │ │ ├─ com.lihaoyi:sourcecode_2.13:0.2.1 │ │ └─ org.scala-lang:scala-library:2.13.2 │ └─ org.scalameta:fastparse_2.13:1.0.1 │ ├─ com.lihaoyi:sourcecode_2.13:0.1.7 -> 0.2.1 (possible incompatibility) │ ├─ org.scala-lang:scala-library:2.13.0 -> 2.13.2 │ └─ org.scalameta:fastparse-utils_2.13:1.0.1 │ ├─ com.lihaoyi:sourcecode_2.13:0.1.7 -> 0.2.1 (possible incompatibility) │ └─ org.scala-lang:scala-library:2.13.0 -> 2.13.2 ├─ org.scala-lang:scala-library:2.13.2

It's impossible in sbt without disabling things as it has this OverrideScalaMediator (sbt/sbt#2634) which keeps scala-compiler/scala-library/scala-reflect in sync. And then there are also, in the compiler, various sanity checks on the classes in the library, so it crashes early if you mix major versions for example.

project/ScalafixBuild.scala

project/Dependencies.scala

…project rules We were failing if the scalaversion is not exactly the same than the one used to compile explicitResultType rule. Now it can work with the 3 last versions, and we have tests to verify that it works as expected

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>

…for rules (scalacenter#1174) * Add support for the 3 last versions of scala212 and scala213 for the project rules We were failing if the scalaversion is not exactly the same than the one used to compile explicitResultType rule. Now it can work with the 3 last versions, and we have tests to verify that it works as expected * Update project/ScalafixBuild.scala Co-authored-by: Brice Jaglin <bjaglin@gmail.com> * Update project/Dependencies.scala Co-authored-by: Brice Jaglin <bjaglin@gmail.com> Co-authored-by: Brice Jaglin <bjaglin@gmail.com>

…version for rules (scalacenter#1174)" This reverts commit c3c9d0a.

… binary version for rules (scalacenter#1174)"" This reverts commit 0b997e4.

…for rules (scalacenter#1174) * Add support for the 3 last versions of scala212 and scala213 for the project rules We were failing if the scalaversion is not exactly the same than the one used to compile explicitResultType rule. Now it can work with the 3 last versions, and we have tests to verify that it works as expected * Update project/ScalafixBuild.scala Co-authored-by: Brice Jaglin <bjaglin@gmail.com> * Update project/Dependencies.scala Co-authored-by: Brice Jaglin <bjaglin@gmail.com> Co-authored-by: Brice Jaglin <bjaglin@gmail.com>

…version for rules (scalacenter#1174)" This reverts commit 3ae1982.

…version for rules (scalacenter#1174)" This reverts commit f7adc0e.

mlachkar force-pushed the scalaVersion branch 2 times, most recently from 0904637 to a51d230 Compare June 22, 2020 12:22

bjaglin reviewed Jun 22, 2020

View reviewed changes

mlachkar mentioned this pull request Jun 24, 2020

document sbt-scalafix scalafixScalaBinaryVersion #1166

Merged

mlachkar force-pushed the scalaVersion branch from a51d230 to ea80ab5 Compare June 30, 2020 15:33

mlachkar changed the title ~~[WIP] Add support for 3 last version of scala for each binary version~~ Add support for the 3 last versions of scala for each binary version for explicitResultType rule Jun 30, 2020

mlachkar force-pushed the scalaVersion branch 3 times, most recently from 49e734c to 26303fe Compare June 30, 2020 16:00

mlachkar commented Jun 30, 2020

View reviewed changes

mlachkar requested a review from bjaglin June 30, 2020 16:02

bjaglin reviewed Jun 30, 2020

View reviewed changes

mlachkar force-pushed the scalaVersion branch 3 times, most recently from 1abcfe3 to 16be6bd Compare July 1, 2020 13:02

bjaglin approved these changes Jul 1, 2020

View reviewed changes

mlachkar force-pushed the scalaVersion branch from 16be6bd to 771e792 Compare July 1, 2020 14:23

bjaglin reviewed Jul 1, 2020

View reviewed changes

mlachkar changed the title ~~Add support for the 3 last versions of scala for each binary version for explicitResultType rule~~ Add support for the 3 last versions of scala for each binary version for rules Jul 2, 2020

mlachkar force-pushed the scalaVersion branch from 771e792 to cc7b522 Compare July 2, 2020 09:12

bjaglin approved these changes Jul 2, 2020

View reviewed changes

project/ScalafixBuild.scala Outdated Show resolved Hide resolved

project/Dependencies.scala Outdated Show resolved Hide resolved

mlachkar force-pushed the scalaVersion branch from cc7b522 to 2533c50 Compare July 2, 2020 09:21

mlachkar force-pushed the scalaVersion branch from 2533c50 to b201627 Compare July 2, 2020 09:31

Update project/ScalafixBuild.scala

f3ba2d3

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>

Update project/Dependencies.scala

d35e767

Co-authored-by: Brice Jaglin <bjaglin@gmail.com>

mlachkar merged commit f7adc0e into scalacenter:master Jul 2, 2020

mlachkar deleted the scalaVersion branch July 2, 2020 13:05

mlachkar added a commit to mlachkar/scalafix that referenced this pull request Jul 2, 2020

Revert "Add support for the 3 last versions of scala for each binary …

0b997e4

…version for rules (scalacenter#1174)" This reverts commit c3c9d0a.

mlachkar added a commit to mlachkar/scalafix that referenced this pull request Jul 2, 2020

Revert "Revert "Add support for the 3 last versions of scala for each…

67b4149

… binary version for rules (scalacenter#1174)"" This reverts commit 0b997e4.

mlachkar added a commit to mlachkar/scalafix that referenced this pull request Jul 2, 2020

Revert "Add support for the 3 last versions of scala for each binary …

4e9451c

…version for rules (scalacenter#1174)" This reverts commit 3ae1982.

mlachkar added a commit to mlachkar/scalafix that referenced this pull request Jul 2, 2020

Revert "Add support for the 3 last versions of scala for each binary …

20d90b4

…version for rules (scalacenter#1174)" This reverts commit f7adc0e.

bjaglin pushed a commit to bjaglin/scalafix that referenced this pull request Jul 3, 2020

Revert "Add support for the 3 last versions of scala for each binary …

7f0fb33

…version for rules (scalacenter#1174)" This reverts commit f7adc0e.

bjaglin pushed a commit to bjaglin/scalafix that referenced this pull request Jul 3, 2020

Revert "Add support for the 3 last versions of scala for each binary …

ce92c21

…version for rules (scalacenter#1174)" This reverts commit f7adc0e.

bjaglin mentioned this pull request Jul 3, 2020

fix ci-213-windows #1198

Closed

bjaglin mentioned this pull request Nov 6, 2020

Separate versioning of sbt-scalafix and scalafix-core #1146

Open

bjaglin mentioned this pull request Mar 24, 2022

all scala 2.x patch releases are supported #1576

Merged

	s"Only compatible with Scala $supportedScalaVersions."
	s"Only compatible with Scala ${supportedScalaVersions.values.flatten}."

	"supportedScalaVersionforRules" -> supportedScalaVersionforRules
	"supportedScalaVersions" -> supportedScalaVersionforRules

	testRulesFor(scala213, s)
	testRulesAgainstPreviousScalaVersions(scala213, s)

	testRulesFor(scala212, s)
	testRulesAgainstPreviousScalaVersions(scala212, s)

	testRulesFor(scala211, s)
	testRulesAgainstPreviousScalaVersions(scala211, s)

	val runtimeScalaVersion = RulesBuildInfo.scalaVersion
	val compilerScalaVersion = RulesBuildInfo.scalaVersion

Add support for the 3 last versions of scala for each binary version for rules #1174

Add support for the 3 last versions of scala for each binary version for rules #1174

Conversation

mlachkar commented Jun 22, 2020

bjaglin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlachkar commented Jun 22, 2020

bjaglin commented Jun 22, 2020 • edited Loading

mlachkar commented Jun 23, 2020

Choose a reason for hiding this comment

bjaglin Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

bjaglin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bjaglin Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

inputBinaryScalaVersion == runtimeBinaryScalaVersion

inputBinaryScalaVersion != runtimeBinaryScalaVersion

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bjaglin Jun 30, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mlachkar commented Jul 1, 2020

bjaglin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bjaglin left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bjaglin Jul 1, 2020 • edited Loading

Choose a reason for hiding this comment

bjaglin Jul 1, 2020 • edited Loading

Choose a reason for hiding this comment

bjaglin Jul 1, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bjaglin Jul 2, 2020 • edited Loading

Choose a reason for hiding this comment

dwijnand Jul 2, 2020 • edited Loading

Choose a reason for hiding this comment

bjaglin commented Jun 22, 2020 •

edited

Loading

bjaglin Jun 30, 2020 •

edited

Loading

bjaglin Jun 30, 2020 •

edited

Loading

bjaglin Jun 30, 2020 •

edited

Loading

bjaglin left a comment •

edited

Loading

bjaglin Jul 1, 2020 •

edited

Loading

bjaglin Jul 1, 2020 •

edited

Loading

bjaglin Jul 1, 2020 •

edited

Loading

bjaglin Jul 2, 2020 •

edited

Loading

dwijnand Jul 2, 2020 •

edited

Loading