-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable MiMa against latest stable version for published modules #1177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
commented
Jun 23, 2020
Seq( | ||
// removed semanticdb-sbt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bjaglin
force-pushed
the
mima
branch
3 times, most recently
from
June 24, 2020 01:25
224bb83
to
d155300
Compare
* scalafix-cli * scalafix-core * scalafix-interfaces * scalafix-reflect * scalafix-rules * scalafix-testkit
bjaglin
commented
Jun 30, 2020
ProblemFilters.exclude[DirectMissingMethodProblem]("scalafix.patch.PatchOps.rename"), | ||
ProblemFilters.exclude[DirectMissingMethodProblem]("scalafix.testkit.SemanticRuleSuite.LintAssertion"), | ||
ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package$"), | ||
ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package"), | ||
ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.DiffAssertions"), | ||
ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.SemanticRuleSuite"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mlachkar
approved these changes
Jul 1, 2020
olafurpg
approved these changes
Jul 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for #1176 and to prepare for 1.0