Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable MiMa against latest stable version for published modules #1177

Merged
merged 1 commit into from
Jul 1, 2020

Conversation

bjaglin
Copy link
Collaborator

@bjaglin bjaglin commented Jun 23, 2020

Useful for #1176 and to prepare for 1.0

  • scalafix-cli
  • scalafix-core
  • scalafix-interfaces
  • scalafix-reflect
  • scalafix-rules
  • scalafix-testkit

@bjaglin bjaglin requested review from olafurpg and mlachkar June 23, 2020 22:57
Seq(
// removed semanticdb-sbt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjaglin bjaglin force-pushed the mima branch 3 times, most recently from 224bb83 to d155300 Compare June 24, 2020 01:25
@bjaglin bjaglin marked this pull request as ready for review June 24, 2020 01:31
* scalafix-cli
* scalafix-core
* scalafix-interfaces
* scalafix-reflect
* scalafix-rules
* scalafix-testkit
ProblemFilters.exclude[DirectMissingMethodProblem]("scalafix.patch.PatchOps.rename"),
ProblemFilters.exclude[DirectMissingMethodProblem]("scalafix.testkit.SemanticRuleSuite.LintAssertion"),
ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package$"),
ProblemFilters.exclude[MissingClassProblem]("scalafix.testkit.package"),
ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.DiffAssertions"),
ProblemFilters.exclude[MissingTypesProblem]("scalafix.testkit.SemanticRuleSuite"),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bjaglin bjaglin merged commit 3f7dd31 into scalacenter:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants