Fix #1180 - ExplicitResultTypes for implicit members of local traits #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implicits in Templates
We have already used `mods.exists(_.is[Mod.Final])` to check `defn` has `final` Mod. So we can also use that logic to check `implicit` Mod. I found the old code is unnecessarily complex and IntelliJ (with latest Scala plugin - version 2020.1.1204), like me :D, incorrectly mark the `isRuleCandidate` calls red because it don't understand the implicit `Extract[D, Mod]` param of `isRuleCandidate`.
giabao
added a commit
to giabao/scalafix
that referenced
this pull request
Jun 27, 2020
Output changes are caused by scalacenter#1181
Output changes are caused by scalacenter#1181
bjaglin
approved these changes
Jul 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1180
Also fix:
ExplicitResultTypes.skipLocalImplicits = falsehas no effect.