Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScalafixImplSuite test and add a test for configuration path #1224

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Fix ScalafixImplSuite test and add a test for configuration path #1224

merged 1 commit into from
Aug 28, 2020

Conversation

mlachkar
Copy link
Collaborator

Right now, even if you specify a config file = None, scalafix still reads the default config path.
The goal is to document this behavior through a test

@mlachkar mlachkar force-pushed the config branch 2 times, most recently from f5b77a2 to 2ea1c19 Compare August 11, 2020 08:24
@mlachkar
Copy link
Collaborator Author

This test was running only for 2.12. It tests the interface implementations.
Now that we cross-compile example-rule, it's possible to run this test for the 3 scala versions.

@mlachkar mlachkar force-pushed the config branch 2 times, most recently from 7f8fcb6 to 2647d71 Compare August 12, 2020 15:52
bjaglin
bjaglin approved these changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have added a few minor suggestions

scalafix-tests/unit/src/test/scala/scalafix/tests/cli/ScalafixImplSuite.scala Outdated Show resolved Hide resolved
scalafix-tests/unit/src/test/scala/scalafix/tests/cli/ScalafixImplSuite.scala Show resolved Hide resolved
scalafix-tests/unit/src/test/scala/scalafix/tests/cli/ScalafixImplSuite.scala Outdated Show resolved Hide resolved
@mlachkar mlachkar merged commit be5dcc8 into scalacenter:master Aug 28, 2020
@mlachkar mlachkar deleted the config branch June 25, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjaglin bjaglin bjaglin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlachkar @bjaglin