allow building on JDK 15 #1278
Merged
allow building on JDK 15 #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjaglin
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
LGTM as we use Java8+ anyway on CI for the build. See
Line 8 in 25e2e79
|
From my understanding based on #1279, there is no point trying to run CI on JDK15 (to prevent this to regress) until 2.13.4 is out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know anything about this flag, but JDK 15 doesn't accept it.
A possible alternate approach here would be to add
-XX:+IgnoreUnrecognizedVMOptions.