Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mega-Linter in list of integrating tools #1312

Merged
merged 4 commits into from
Jan 5, 2021

Conversation

nvuillam
Copy link
Contributor

@nvuillam nvuillam commented Jan 4, 2021

Hi, thanks for your linter :)

I integrated it in Mega-Linter, can I put a link here ? :)

Internal documentation is https://nvuillam.github.io/mega-linter/descriptors/scala_scalafix/, do you have remarks ?

Best regards :)

@bjaglin
Copy link
Collaborator

bjaglin commented Jan 5, 2021

Thanks for the integration @nvuillam.

One gotcha is that - as far as I can see - you are running scalafix without prior scalax compilation & semanticdb generation, so you cannot provide any of the semantic options to the CLI. That means that usage of scalafix is limited to built-in syntactic rules. I think it would be useful to mention this limitation in your documentation and in the link on the Scalafix documentation.

@nvuillam
Copy link
Contributor Author

nvuillam commented Jan 5, 2021

Thanks for your reply :)

Is there a way to generically perform scalax compilation and semanticdb generation via cli ?

  • If yes I may be able to run them before calling scalafix
  • If not I can just update the doc to specify the use of scalafix in Mega-Linter is limited to built-in syntactic rules

@bjaglin
Copy link
Collaborator

bjaglin commented Jan 5, 2021

Is there a way to generically perform scalax compilation and semanticdb generation via cli ?

scalafix-core may compile and generate sources on demand, but this feature is not documented and very fragile, so the short answer is no. That's why I also suggest to simply mention this limitation rather than trying to overcome it.

@nvuillam
Copy link
Contributor Author

nvuillam commented Jan 5, 2021

Updated !

Is is ok like that ? https://nvuillam.github.io/mega-linter/descriptors/scala_scalafix/

( you may use Squash & Merge option to avoid useless commits in master )
@nvuillam
Copy link
Contributor Author

nvuillam commented Jan 5, 2021

I also updated my PR (online in github editor, so you may use Squash & merge option to avoid useless commits in master )

Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion for the intro of https://nvuillam.github.io/mega-linter/descriptors/scala_scalafix/ focusing on the user-facing limitations

Scalafix lints and fixes scala files

docs/users/installation.md Outdated Show resolved Hide resolved
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
@nvuillam
Copy link
Contributor Author

nvuillam commented Jan 5, 2021

as you wish :)

@bjaglin bjaglin merged commit bfaf275 into scalacenter:master Jan 5, 2021
@nvuillam nvuillam deleted the patch-1 branch January 5, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants