-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add triggered config description to docs #1375
add triggered config description to docs #1375
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Please see my suggestions above. @mlachkar do you have some feedback? you are probably less biased as you didn't follow the previous discussions.
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
Thank you for reviewing and suggestion! I have reflected both 👍 |
1. If you run many semantic rules by default, the last one(s) to run might see | ||
stale information and fail the invocation, which needs to be re-run manually. | ||
This is [not specific to `scalafixOnCompile`](https://github.com/scalacenter/scalafix/issues/1204), | ||
but the problem becomes much more visible with it. | ||
1. To keep the overhad minimal, `scalafixCaching` is automatically enabled when | ||
1. To keep the overhead minimal, `scalafixCaching` is automatically enabled when |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
The documentation is super clear! thanks for the PR. |
ref: #1217 scalacenter/sbt-scalafix#169
This is a follow up PR to introduce
--triggered
args andtriggered
configuration prefix to run scalafix on compilation with different config.