Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add triggered config description to docs #1375

Merged
merged 4 commits into from
May 16, 2021

Conversation

taisukeoe
Copy link
Contributor

ref: #1217 scalacenter/sbt-scalafix#169

This is a follow up PR to introduce --triggered args and triggered configuration prefix to run scalafix on compilation with different config.

Copy link
Collaborator

@bjaglin bjaglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please see my suggestions above. @mlachkar do you have some feedback? you are probably less biased as you didn't follow the previous discussions.

docs/users/installation.md Show resolved Hide resolved
docs/users/installation.md Outdated Show resolved Hide resolved
docs/users/configuration.md Outdated Show resolved Hide resolved
taisukeoe and others added 2 commits April 21, 2021 11:51
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
Co-authored-by: Brice Jaglin <bjaglin@gmail.com>
@taisukeoe
Copy link
Contributor Author

Thank you for reviewing and suggestion! I have reflected both 👍

1. If you run many semantic rules by default, the last one(s) to run might see
stale information and fail the invocation, which needs to be re-run manually.
This is [not specific to `scalafixOnCompile`](https://github.com/scalacenter/scalafix/issues/1204),
but the problem becomes much more visible with it.
1. To keep the overhad minimal, `scalafixCaching` is automatically enabled when
1. To keep the overhead minimal, `scalafixCaching` is automatically enabled when
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mlachkar
Copy link
Collaborator

The documentation is super clear! thanks for the PR.

@bjaglin bjaglin merged commit a50b823 into scalacenter:main May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants