Update scalameta, semanticdb-scalac-core, ... to 4.5.5 #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semanticdb-scalac & scalameta parser behavior regarding Term.ApplyInfix is now aligned with Scala 3 (parens tokens are no longer included). This bugfix will cause Term.ApplyInfix single-arg lookup to fail if scalafix is ran against semanticdb files generated with older semanticdb-scalac because of the mismatch in arg position.
bjaglin
force-pushed
the
update/scalameta-4.5.5
branch
from
ac32706 to
dca79f3
Compare
bjaglin
reviewed
May 1, 2022
Comment on lines
-25
to
-27
| // The symbol lookup fails against Scala 3.1.1 SemanticDB as the position | ||
| // there excludes surrounding parentheses while 2.x (scalac-semanticdb) and | ||
| // the parser include them |
|
Amended the commit to test the impact & highlight the side effect of scalameta/scalameta#2736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
from 4.5.4 to 4.5.5.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conffile.Have a fantastic day writing Scala!
Adjust future updates
Add this to your
.scala-steward.conffile to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency:
labels: library-update, early-semver-patch, semver-spec-patch, commit-count:1